Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 664583007: Avoid subtree style recalc for :-webkit-full-page-media. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 1 month ago
Reviewers:
chrishtr, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Avoid subtree style recalc for :-webkit-full-page-media. Do not let the presence of a :-webkit-full-page-media selector require a sub-tree style recalc. I did not find a way to test style invalidation inside a media document, so I made a test with the negated selector instead. R=chrishtr@chromium.org,esprehn@chromium.org BUG=425070 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184448

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
A LayoutTests/fast/css/invalidation/full-page-media.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/full-page-media-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
rune
6 years, 2 months ago (2014-10-20 21:53:41 UTC) #1
rune
PTAL
6 years, 2 months ago (2014-10-24 08:50:43 UTC) #2
esprehn
lgtm
6 years, 1 month ago (2014-10-25 06:11:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664583007/20001
6 years, 1 month ago (2014-10-27 12:56:01 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 13:56:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184448

Powered by Google App Engine
This is Rietveld 408576698