Improve keyboard navigation on 'Manage search engines' options page

chrome/browser/resources/options/search_engine_manager_engine_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @typedef {{canBeDefault: boolean,
  *            canBeEdited: boolean,
  *            canBeRemoved: boolean,
  *            default: boolean,
  *            displayName: string,
@@ skipping 121 matching lines @@
       nameColEl.appendChild(nameEl);
 
       // Then the keyword column.
       var keywordEl = this.createEditableTextCell(engine.keyword);
       keywordEl.className = 'keyword-column';
       keywordEl.classList.add('weakrtl');
       this.contentElement.appendChild(keywordEl);
 
       // And the URL column.
       var urlEl = this.createEditableTextCell(engine.url);
+      var makeDefaultButtonEl = null;

[Dan Beam, 2014/10/18 01:35:44]

probably don't need the "= null"

       // Extensions should not display a URL column.
       if (!engine.isExtension) {
         var urlWithButtonEl = this.ownerDocument.createElement('div');
         urlWithButtonEl.appendChild(urlEl);
         urlWithButtonEl.className = 'url-column';
         urlWithButtonEl.classList.add('weakrtl');
         this.contentElement.appendChild(urlWithButtonEl);
         // Add the Make Default button. Temporary until drag-and-drop
         // re-ordering is implemented. When this is removed, remove the extra
         // div above.
         if (engine.canBeDefault) {
-          var makeDefaultButtonEl = this.ownerDocument.createElement('button');
+          makeDefaultButtonEl = this.ownerDocument.createElement('button');
           makeDefaultButtonEl.className =
               'custom-appearance list-inline-button';
           makeDefaultButtonEl.textContent =
               loadTimeData.getString('makeDefaultSearchEngineButton');
           makeDefaultButtonEl.onclick = function(e) {
             chrome.send('managerSetDefaultSearchEngine', [engine.modelIndex]);
           };
           makeDefaultButtonEl.onmousedown = function(e) {
             // Don't select the row when clicking the button.
             e.stopPropagation();
@@ skipping 21 matching lines @@
 
       if (this.isPlaceholder) {
         this.nameField_.placeholder =
             loadTimeData.getString('searchEngineTableNamePlaceholder');
         this.keywordField_.placeholder =
             loadTimeData.getString('searchEngineTableKeywordPlaceholder');
         this.urlField_.placeholder =
             loadTimeData.getString('searchEngineTableURLPlaceholder');
       }
 
+      this.setFocusableColumnIndex(this.nameField_, 0);
+      this.setFocusableColumnIndex(this.keywordField_, 1);
+      this.setFocusableColumnIndex(this.urlField_, 2);
+      this.setFocusableColumnIndex(makeDefaultButtonEl, 3);
+      this.setFocusableColumnIndex(this.closeButtonElement, 4);
+      
       var fields = [this.nameField_, this.keywordField_, this.urlField_];
         for (var i = 0; i < fields.length; i++) {
         fields[i].oninput = this.startFieldValidation_.bind(this);
       }
 
       // Listen for edit events.
       if (engine.canBeEdited) {
         this.addEventListener('edit', this.onEditStarted_.bind(this));
         this.addEventListener('canceledit', this.onEditCancelled_.bind(this));
         this.addEventListener('commitedit', this.onEditCommitted_.bind(this));
@@ skipping 160 matching lines @@
     },
   };
 
   // Export
   return {
     SearchEngineList: SearchEngineList
   };
 
 });