Improve keyboard navigation on 'Manage search engines' options page

chrome/browser/resources/options/autofill_options_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.autofillOptions', function() {
   /** @const */ var DeletableItem = options.DeletableItem;
   /** @const */ var DeletableItemList = options.DeletableItemList;
   /** @const */ var InlineEditableItem = options.InlineEditableItem;
   /** @const */ var InlineEditableItemList = options.InlineEditableItemList;
 
@@ skipping 45 matching lines @@
       var label = this.ownerDocument.createElement('div');
       label.className = 'autofill-list-item';
       label.textContent = this.label;
       this.contentElement.appendChild(label);
 
       // The 'Edit' button.
       var editButtonEl = AutofillEditProfileButton(
         this.guid,
         AutofillOptions.loadAddressEditor);
       this.contentElement.appendChild(editButtonEl);
+
+      this.closeButtonFocusable = true;

[Dan Beam, 2014/10/18 01:35:43]

what's the benefit to this very specific accessor over just using the current
|closeButtonElement| like this:

  this.closeButtonElement.tabIndex = 0;

or

  this.closeButtonElement.removeAttribute('tabindex');

?  tabIndex will always be public (unless we attempt to change this), so it
seems odd to try to hide it otherwise...

     },
   };
 
   /**
    * Creates a new credit card list item.
    * @param {Array} entry An array of the form [guid, label, icon].
    * @constructor
    * @extends {options.DeletableItem}
    */
   function CreditCardListItem(entry) {
@@ skipping 25 matching lines @@
       var icon = this.ownerDocument.createElement('img');
       icon.src = this.icon;
       icon.alt = this.description;
       this.contentElement.appendChild(icon);
 
       // The 'Edit' button.
       var editButtonEl = AutofillEditProfileButton(
         this.guid,
         AutofillOptions.loadCreditCardEditor);
       this.contentElement.appendChild(editButtonEl);
+
+      this.closeButtonFocusable = true;
     },
   };
 
   /**
    * Creates a new value list item.
    * @param {options.autofillOptions.AutofillValuesList} list The parent list of
    *     this item.
    * @param {string} entry A string value.
    * @constructor
    * @extends {options.InlineEditableItem}
@@ skipping 440 matching lines @@
     CreditCardListItem: CreditCardListItem,
     ValuesListItem: ValuesListItem,
     NameListItem: NameListItem,
     AutofillAddressList: AutofillAddressList,
     AutofillCreditCardList: AutofillCreditCardList,
     AutofillValuesList: AutofillValuesList,
     AutofillNameValuesList: AutofillNameValuesList,
     AutofillPhoneValuesList: AutofillPhoneValuesList,
   };
 });