Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 664573004: Live the dream (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Live the dream This CL plumbs the data pipe from the network stack all the way to the parser thread. We now drain the data pipe on the parser thread, which means network bytes don't need to transit the main thread to reach the parser. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/33a3268585b589f7dcc79cf437170e8c432b4971

Patch Set 1 #

Patch Set 2 : DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -605 lines) Patch
M sky/engine/core/DEPS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/core.gni View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DecodedDataDocumentParser.h View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/dom/DecodedDataDocumentParser.cpp View 2 chunks +0 lines, -30 lines 0 comments Download
M sky/engine/core/dom/Document.h View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/dom/DocumentParser.h View 3 chunks +2 lines, -18 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImportLoader.h View 3 chunks +1 line, -16 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImportLoader.cpp View 6 chunks +5 lines, -23 lines 0 comments Download
M sky/engine/core/html/parser/BackgroundHTMLParser.h View 3 chunks +12 lines, -6 lines 0 comments Download
M sky/engine/core/html/parser/BackgroundHTMLParser.cpp View 2 chunks +14 lines, -18 lines 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.h View 4 chunks +6 lines, -26 lines 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.cpp View 18 chunks +32 lines, -288 lines 0 comments Download
M sky/engine/core/html/parser/HTMLParserOptions.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTreeBuilder.cpp View 3 chunks +0 lines, -11 lines 0 comments Download
D sky/engine/core/loader/DocumentWriter.h View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/engine/core/loader/DocumentWriter.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
M sky/engine/core/loader/MojoLoader.h View 2 chunks +1 line, -10 lines 0 comments Download
M sky/engine/core/loader/MojoLoader.cpp View 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
6 years, 2 months ago (2014-10-24 23:44:59 UTC) #1
eseidel
lgtm
6 years, 2 months ago (2014-10-24 23:48:38 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 2 months ago (2014-10-24 23:49:34 UTC) #5
abarth-chromium
6 years, 2 months ago (2014-10-24 23:52:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
33a3268585b589f7dcc79cf437170e8c432b4971.

Powered by Google App Engine
This is Rietveld 408576698