Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 664573003: Fix compile issues in sky on android (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M sky/engine/BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download
M sky/engine/core/dom/ElementRareData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/heap/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/viewer/platform/webthemeengine_impl.cc View 6 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
6 years, 1 month ago (2014-10-24 22:04:50 UTC) #1
abarth-chromium
lgtm
6 years, 1 month ago (2014-10-24 22:06:29 UTC) #2
jamesr
6 years, 1 month ago (2014-10-24 22:07:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d6a2df6c908c5094a49bde2d66ac2f8d1628fc2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698