Issue 664563002: Restructured alerts-history endpoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 664563002: Restructured alerts-history endpoint (Closed)

Created:
6 years, 2 months ago by Sergiy Byelozyorov

Modified:
6 years, 2 months ago

Reviewers:
ojan

CC:
ojan, blink-reviews, cbiesinger, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, michaelpg, szager1, teravest

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Restructured alerts-history endpoint Alerts history will return a list of IDs, which can then be used to get actual alerts from history. This allows to avoid exceeding memory and response size limits when processing the query. BUG=416182 R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183845

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -25 lines)			Patch
M	Tools/GardeningServer/alerts.py	View	3 chunks	+39 lines, -20 lines	0 comments	Download
M	Tools/GardeningServer/alerts_test.py	View	2 chunks	+50 lines, -5 lines	0 comments	Download
M	Tools/GardeningServer/app.yaml	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664563002/1

6 years, 2 months ago (2014-10-16 21:45:16 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 183845

6 years, 2 months ago (2014-10-17 00:06:13 UTC) #5

Sergiy Byelozyorov

6 years, 2 months ago (2014-10-17 11:38:45 UTC) #6

Message was sent while issue was closed.

Deployed new version to sheriff-o-matic.appspot.com