Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 664553007: Cleanup: Put more chrome/ code behind ENABLE_EXTENSIONS ifdefs. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Put more chrome/ code behind ENABLE_EXTENSIONS ifdefs. Committed: https://crrev.com/a84d8e63b324924aa3d838b2bea9771b51ddfc2f Cr-Commit-Position: refs/heads/master@{#300177}

Patch Set 1 #

Patch Set 2 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -17 lines) Patch
M chrome/browser/ui/browser.h View 5 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 9 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 6 chunks +6 lines, -2 lines 0 comments Download
M chrome/common/localized_error.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/localized_error.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M chrome/renderer/chrome_mock_render_thread.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_mock_render_thread.cc View 5 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
6 years, 2 months ago (2014-10-17 19:13:45 UTC) #2
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-10-17 20:26:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664553007/20001
6 years, 2 months ago (2014-10-17 21:25:39 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-17 22:28:04 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 22:28:46 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a84d8e63b324924aa3d838b2bea9771b51ddfc2f
Cr-Commit-Position: refs/heads/master@{#300177}

Powered by Google App Engine
This is Rietveld 408576698