Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 664543003: Benchmark sample for SDK (Closed)

Created:
6 years, 1 month ago by nfullagar1
Modified:
6 years, 1 month ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Benchmark sample for SDK BUG=https://code.google.com/p/nativeclient/issues/detail?id=3987 TEST=NaCl SDK example and run on NaCl Perf Bots R=bradnelson@chromium.org Committed: https://crrev.com/847dd159a44818c2a3c0919bb8c06506f038f4bc Cr-Commit-Position: refs/heads/master@{#302183}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -8 lines) Patch
M native_client_sdk/src/build_tools/build_app.py View 1 chunk +3 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/build_projects.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/generate_index.py View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/parse_dsc.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 chunk +1 line, -0 lines 0 comments Download
A native_client_sdk/src/examples/benchmarks/example.dsc View 1 chunk +41 lines, -0 lines 1 comment Download
A native_client_sdk/src/examples/benchmarks/example.js View 1 chunk +41 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/benchmarks/framework_ppapi.cc View 1 chunk +82 lines, -0 lines 0 comments Download
A + native_client_sdk/src/examples/benchmarks/index.html View 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nfullagar1
6 years, 1 month ago (2014-10-30 18:20:32 UTC) #1
bradn
lgtm https://codereview.chromium.org/664543003/diff/1/native_client_sdk/src/examples/benchmarks/example.dsc File native_client_sdk/src/examples/benchmarks/example.dsc (right): https://codereview.chromium.org/664543003/diff/1/native_client_sdk/src/examples/benchmarks/example.dsc#newcode28 native_client_sdk/src/examples/benchmarks/example.dsc:28: 'LIBS': ['ppapi_simple', 'nacl_io', 'sdk_util', 'ppapi_cpp', 'ppapi', 'pthread'] >80
6 years, 1 month ago (2014-10-30 18:28:17 UTC) #3
nfullagar
On 2014/10/30 18:28:17, bradn wrote: > lgtm > > https://codereview.chromium.org/664543003/diff/1/native_client_sdk/src/examples/benchmarks/example.dsc > File native_client_sdk/src/examples/benchmarks/example.dsc (right): > ...
6 years, 1 month ago (2014-10-30 20:46:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664543003/1
6 years, 1 month ago (2014-10-30 22:18:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 23:03:57 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 23:04:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/847dd159a44818c2a3c0919bb8c06506f038f4bc
Cr-Commit-Position: refs/heads/master@{#302183}

Powered by Google App Engine
This is Rietveld 408576698