Ensure athena_unittests is run for chromeos tryjobs.

Ensure athena_unittests is run for chromeos tryjobs.

BUG=424093
Committed: https://crrev.com/84afadbb6012ffb97c9365e2d4acc2d75464c873
Cr-Commit-Position: refs/heads/master@{#299958}

[jam, 2014-10-16 16:16:28]

jam@chromium.org changed reviewers:
+ oshima@chromium.org, sky@chromium.org

[oshima, 2014-10-16 16:28:42]

lgtm

thanks!

[Mr4D (OOO till 08-26), 2014-10-16 17:17:25]

skuhne@chromium.org changed reviewers:
+ skuhne@chromium.org

[Mr4D (OOO till 08-26), 2014-10-16 17:17:25]

https://codereview.chromium.org/664543002/diff/1/testing/buildbot/chromium_tr...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/664543002/diff/1/testing/buildbot/chromium_tr...
testing/buildbot/chromium_trybot.json:221: "chromium_chromeos",
Before I removed it we also used to check clang. I suppose we want to keep that
as well?

[jam, 2014-10-16 17:20:28]

On 2014/10/16 17:17:25, Mr4D wrote:
>
https://codereview.chromium.org/664543002/diff/1/testing/buildbot/chromium_tr...
> File testing/buildbot/chromium_trybot.json (right):
> 
>
https://codereview.chromium.org/664543002/diff/1/testing/buildbot/chromium_tr...
> testing/buildbot/chromium_trybot.json:221: "chromium_chromeos",
> Before I removed it we also used to check clang. I suppose we want to keep
that
> as well?

I have no idea. Can you guys take over this cl then?

Just make sure that if athena_unittests is running on main waterfall it's also
on trybots asap, or we should remove it from main waterfall linux_chromeos.

[oshima, 2014-10-16 17:31:56]

On 2014/10/16 17:20:28, jam wrote:
> On 2014/10/16 17:17:25, Mr4D wrote:
> >
>
https://codereview.chromium.org/664543002/diff/1/testing/buildbot/chromium_tr...
> > File testing/buildbot/chromium_trybot.json (right):
> > 
> >
>
https://codereview.chromium.org/664543002/diff/1/testing/buildbot/chromium_tr...
> > testing/buildbot/chromium_trybot.json:221: "chromium_chromeos",
> > Before I removed it we also used to check clang. I suppose we want to keep
> that
> > as well?
> 
> I have no idea. Can you guys take over this cl then?

AFAIK, clang bots doesn't run test, so it shouldn't be necessary.

> 
> Just make sure that if athena_unittests is running on main waterfall it's also
> on trybots asap, or we should remove it from main waterfall linux_chromeos.

We still want to keep this on chromeos bots, so let's land this.

[jam, 2014-10-16 18:22:14]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-10-16 18:24:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664543002/1

[commit-bot: I haz the power, 2014-10-16 19:42:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-16 19:44:29]

Patchset 1 (id:??) landed as
https://crrev.com/84afadbb6012ffb97c9365e2d4acc2d75464c873
Cr-Commit-Position: refs/heads/master@{#299958}