Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 664523003: improve element parameter string returned by local suggestion computer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/local_computer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/completion_test_util.dart
diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart
index 0931a4e84a2a00a775695c70e498b5b884e9252d..3c830a56a9190d79b64a9cf66dfdf04f38dec9d1 100644
--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart
+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart
@@ -107,6 +107,7 @@ class AbstractCompletionTest extends AbstractContextTest {
expect(element, isNotNull);
expect(element.kind, equals(protocol.ElementKind.CLASS));
expect(element.name, equals(name));
+ expect(element.parameters, isNull);
expect(element.returnType, isNull);
return cs;
}
@@ -125,6 +126,10 @@ class AbstractCompletionTest extends AbstractContextTest {
expect(element.kind, equals(protocol.ElementKind.FUNCTION));
expect(element.name, equals(name));
expect(element.isDeprecated, equals(isDeprecated));
+ String param = element.parameters;
+ expect(param, isNotNull);
+ expect(param[0], equals('('));
+ expect(param[param.length - 1], equals(')'));
expect(
element.returnType,
equals(returnType != null ? returnType : 'dynamic'));
@@ -140,6 +145,9 @@ class AbstractCompletionTest extends AbstractContextTest {
expect(element, isNotNull);
expect(element.kind, equals(protocol.ElementKind.GETTER));
expect(element.name, equals(name));
+ //TODO (danrubel) getter should have parameters
+ // but not used in code completion
+ //expect(element.parameters, '()');
expect(
element.returnType,
equals(returnType != null ? returnType : 'dynamic'));
@@ -155,6 +163,7 @@ class AbstractCompletionTest extends AbstractContextTest {
protocol.Element element = cs.element;
expect(element, isNotNull);
expect(element.kind, equals(protocol.ElementKind.LIBRARY));
+ expect(element.parameters, isNull);
expect(element.returnType, isNull);
return cs;
} else {
@@ -174,6 +183,7 @@ class AbstractCompletionTest extends AbstractContextTest {
expect(element, isNotNull);
expect(element.kind, equals(protocol.ElementKind.LOCAL_VARIABLE));
expect(element.name, equals(name));
+ expect(element.parameters, isNull);
expect(
element.returnType,
equals(returnType != null ? returnType : 'dynamic'));
@@ -194,6 +204,10 @@ class AbstractCompletionTest extends AbstractContextTest {
expect(element, isNotNull);
expect(element.kind, equals(protocol.ElementKind.METHOD));
expect(element.name, equals(name));
+ String param = element.parameters;
+ expect(param, isNotNull);
+ expect(param[0], equals('('));
+ expect(param[param.length - 1], equals(')'));
expect(
element.returnType,
equals(returnType != null ? returnType : 'dynamic'));
@@ -210,6 +224,10 @@ class AbstractCompletionTest extends AbstractContextTest {
expect(element, isNotNull);
expect(element.kind, equals(protocol.ElementKind.CONSTRUCTOR));
expect(element.name, equals(name));
+ String param = element.parameters;
+ expect(param, isNotNull);
+ expect(param[0], equals('('));
+ expect(param[param.length - 1], equals(')'));
expect(element.returnType, equals(returnType));
return cs;
} else {
@@ -228,6 +246,7 @@ class AbstractCompletionTest extends AbstractContextTest {
expect(element, isNotNull);
expect(element.kind, equals(protocol.ElementKind.PARAMETER));
expect(element.name, equals(name));
+ expect(element.parameters, isNull);
expect(
element.returnType,
equals(returnType != null ? returnType : 'dynamic'));
@@ -245,6 +264,8 @@ class AbstractCompletionTest extends AbstractContextTest {
expect(element, isNotNull);
expect(element.kind, equals(protocol.ElementKind.SETTER));
expect(element.name, equals(name));
+ // TODO (danrubel) assert setter param
+ //expect(element.parameters, isNull);
expect(element.returnType, isNull);
return cs;
}
@@ -258,6 +279,7 @@ class AbstractCompletionTest extends AbstractContextTest {
expect(element, isNotNull);
expect(element.kind, equals(protocol.ElementKind.TOP_LEVEL_VARIABLE));
expect(element.name, equals(name));
+ expect(element.parameters, isNull);
//TODO (danrubel) return type level variable 'type' but not as 'returnType'
// expect(
// element.returnType,
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/local_computer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698