Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: pkg/analysis_server/lib/src/services/completion/imported_computer.dart

Issue 664523003: improve element parameter string returned by local suggestion computer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/local_computer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/imported_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
index f02ec34b4994f7b5580b184c2bd2930ed09285f9..d16b80d4f4dc74e01b6572ee1aaaa296c6de2529 100644
--- a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
@@ -196,7 +196,8 @@ class _ImportedVisitor extends GeneralizingAstVisitor<Future<bool>> {
return new Future.value(false);
}
- void _addElementSuggestion(Element element, bool typesOnly, bool excludeVoidReturn, CompletionRelevance relevance) {
+ void _addElementSuggestion(Element element, bool typesOnly,
+ bool excludeVoidReturn, CompletionRelevance relevance) {
if (element is ExecutableElement) {
if (element.isOperator) {
@@ -246,9 +247,14 @@ class _ImportedVisitor extends GeneralizingAstVisitor<Future<bool>> {
request.suggestions.add(suggestion);
}
- void _addElementSuggestions(List<Element> elements, bool typesOnly, bool excludeVoidReturn) {
+ void _addElementSuggestions(List<Element> elements, bool typesOnly,
+ bool excludeVoidReturn) {
elements.forEach((Element elem) {
- _addElementSuggestion(elem, typesOnly, excludeVoidReturn, CompletionRelevance.DEFAULT);
+ _addElementSuggestion(
+ elem,
+ typesOnly,
+ excludeVoidReturn,
+ CompletionRelevance.DEFAULT);
});
}
@@ -274,7 +280,11 @@ class _ImportedVisitor extends GeneralizingAstVisitor<Future<bool>> {
if (elem is ClassElement) {
classMap[name] = elem;
}
- _addElementSuggestion(elem, typesOnly, excludeVoidReturn, CompletionRelevance.DEFAULT);
+ _addElementSuggestion(
+ elem,
+ typesOnly,
+ excludeVoidReturn,
+ CompletionRelevance.DEFAULT);
});
} else {
// Exclude elements from prefixed imports
@@ -295,7 +305,11 @@ class _ImportedVisitor extends GeneralizingAstVisitor<Future<bool>> {
if (elem is ClassElement) {
classMap[name] = elem;
}
- _addElementSuggestion(elem, typesOnly, excludeVoidReturn, CompletionRelevance.DEFAULT);
+ _addElementSuggestion(
+ elem,
+ typesOnly,
+ excludeVoidReturn,
+ CompletionRelevance.DEFAULT);
});
// Build a list of inherited types that are imported
@@ -317,8 +331,14 @@ class _ImportedVisitor extends GeneralizingAstVisitor<Future<bool>> {
_addElementSuggestions(elem.methods, typesOnly, excludeVoidReturn);
elem.allSupertypes.forEach((InterfaceType type) {
if (visited.add(type.name)) {
- _addElementSuggestions(type.accessors, typesOnly, excludeVoidReturn);
- _addElementSuggestions(type.methods, typesOnly, excludeVoidReturn);
+ _addElementSuggestions(
+ type.accessors,
+ typesOnly,
+ excludeVoidReturn);
+ _addElementSuggestions(
+ type.methods,
+ typesOnly,
+ excludeVoidReturn);
}
});
}
@@ -339,7 +359,11 @@ class _ImportedVisitor extends GeneralizingAstVisitor<Future<bool>> {
!excludedLibs.contains(element.library) &&
!completionSet.contains(element.displayName)) {
if (!typesOnly || element is ClassElement) {
- _addElementSuggestion(element, typesOnly, excludeVoidReturn, CompletionRelevance.LOW);
+ _addElementSuggestion(
+ element,
+ typesOnly,
+ excludeVoidReturn,
+ CompletionRelevance.LOW);
}
}
}
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/local_computer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698