Hide second 'Details' link on extensions page if App Info dialog used

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 /**
  * The type of the extension data object. The definition is based on
  * chrome/browser/ui/webui/extensions/extension_basic_info.cc
  * and
@@ skipping 290 matching lines @@
       }
 
       // The 'Permissions' link.
       var permissions = node.querySelector('.permissions-link');
       permissions.addEventListener('click', function(e) {
         chrome.send('extensionSettingsPermissions', [extension.id]);
         e.preventDefault();
       });
 
       // The 'View in Web Store/View Web Site' link.
       if (extension.homepageUrl) {

[not at google - send to devlin, 2014/10/20 18:32:24]

Seems like it would be simpler to just include "&&
!extension.enableExtensionInfoDialog" in this condition?

         var siteLink = node.querySelector('.site-link');
         siteLink.href = extension.homepageUrl;
         siteLink.textContent = loadTimeData.getString(
                 extension.homepageProvided ? 'extensionSettingsVisitWebsite' :
                                              'extensionSettingsVisitWebStore');
         siteLink.hidden = false;
       }
 
+      // If the ExtensionInfoDialog is enabled, hide the site link (since it's
+      // available from within the dialog anyway).
+      if (extension.enableExtensionInfoDialog) {
+        siteLink.hidden = true;
+      }
+
       if (extension.allow_reload) {
         // The 'Reload' link.
         var reload = node.querySelector('.reload-link');
         reload.addEventListener('click', function(e) {
           chrome.send('extensionSettingsReload', [extension.id]);
           extensionReloadedTimestamp[extension.id] = Date.now();
         });
         reload.hidden = false;
 
         if (extension.is_platform_app) {
@@ skipping 223 matching lines @@
       $('overlay').addEventListener('cancelOverlay', function() {
         this.optionsShown_ = false;
       }.bind(this));
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });