Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 664473002: Pass an Isolate to v8::VisitHandlesWithClassIds (Closed)

Created:
6 years, 2 months ago by haraken
Modified:
6 years, 2 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Pass an Isolate to v8::VisitHandlesWithClassIds The Isolate version of v8::VisitHandlesWithClassIds is needed for https://codereview.chromium.org/651713002/ R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M include/v8.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
haraken
PTAL
6 years, 2 months ago (2014-10-16 08:35:54 UTC) #2
haraken
6 years, 2 months ago (2014-10-16 08:36:08 UTC) #4
dcarney
lgtm
6 years, 2 months ago (2014-10-16 19:06:47 UTC) #5
haraken
6 years, 2 months ago (2014-10-17 00:46:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24671 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698