Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 664413003: Turn ChannelMojo on Mac and Linux (Closed)

Created:
6 years, 2 months ago by Hajime Morrita
Modified:
6 years, 1 month ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Turn ChannelMojo on Mac and Linux I don't see any page_cycler regression locally so I'll try to enable this on trunk as the nex step. This change doesn't turn this on Windows to keep the scope of possible trouble small. BUG=377980 R=viettrungluu@chromium.org, darin@chromium.org Committed: https://crrev.com/45d3cbd888ea1f20145e0f1451a7920a62a6653d Cr-Commit-Position: refs/heads/master@{#304949}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Landing #

Patch Set 3 : Landing #

Patch Set 4 : Updated to ToT #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M ipc/mojo/ipc_channel_mojo.cc View 1 2 3 4 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
Hajime Morrita
6 years, 2 months ago (2014-10-21 18:11:03 UTC) #1
darin (slow to review)
LGTM
6 years, 2 months ago (2014-10-21 18:11:48 UTC) #2
viettrungluu
LGTM w/nit. https://codereview.chromium.org/664413003/diff/1/ipc/mojo/ipc_channel_mojo.cc File ipc/mojo/ipc_channel_mojo.cc (right): https://codereview.chromium.org/664413003/diff/1/ipc/mojo/ipc_channel_mojo.cc#newcode56 ipc/mojo/ipc_channel_mojo.cc:56: // Linux even though this should work ...
6 years, 2 months ago (2014-10-21 18:28:19 UTC) #3
Hajime Morrita
Thanks for the review! Landing. On 2014/10/21 18:28:19, viettrungluu wrote: > LGTM w/nit. > > ...
6 years, 2 months ago (2014-10-21 19:31:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664413003/40001
6 years, 2 months ago (2014-10-21 19:32:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/61070)
6 years, 2 months ago (2014-10-21 20:15:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664413003/80001
6 years, 1 month ago (2014-11-20 00:23:00 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-11-20 01:08:43 UTC) #12
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/45d3cbd888ea1f20145e0f1451a7920a62a6653d Cr-Commit-Position: refs/heads/master@{#304949}
6 years, 1 month ago (2014-11-20 01:10:29 UTC) #13
Hajime Morrita
6 years ago (2014-11-26 17:42:41 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/760753005/ by morrita@chromium.org.

The reason for reverting is: Got a perf regression report. Reverting.
.

Powered by Google App Engine
This is Rietveld 408576698