Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 664383004: Merge ARM sysroot install script with existing x86/amd64 one. (Closed)

Created:
6 years, 2 months ago by Sam Clegg
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang, Torne
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Merge ARM sysroot install script with existing x86/amd64 one. install-debian.wheezy.sysroot.py is now use for ARM also, removing duplication. sysroot location is also now consistent. Committed: https://crrev.com/41d0e08a38f6cc0cb32a2596953a7262c4a9ab02 Cr-Commit-Position: refs/heads/master@{#300746}

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -139 lines) Patch
M .gitignore View 1 2 chunks +1 line, -3 lines 0 comments Download
M DEPS View 2 chunks +10 lines, -10 lines 0 comments Download
M android_webview/tools/webview_licenses.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/linux/install-arm-sysroot.py View 1 chunk +5 lines, -98 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py View 1 2 3 4 7 chunks +53 lines, -26 lines 0 comments Download

Messages

Total messages: 29 (13 generated)
Sam Clegg
https://codereview.chromium.org/664383004/diff/20001/build/linux/install-arm-sysroot.py File build/linux/install-arm-sysroot.py (right): https://codereview.chromium.org/664383004/diff/20001/build/linux/install-arm-sysroot.py#newcode12 build/linux/install-arm-sysroot.py:12: sys.stderr.write(msg) Should I just remove this completely?
6 years, 2 months ago (2014-10-21 20:06:46 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/664383004/diff/20001/build/linux/install-arm-sysroot.py File build/linux/install-arm-sysroot.py (right): https://codereview.chromium.org/664383004/diff/20001/build/linux/install-arm-sysroot.py#newcode12 build/linux/install-arm-sysroot.py:12: sys.stderr.write(msg) On 2014/10/21 20:06:46, Sam Clegg wrote: > ...
6 years, 2 months ago (2014-10-21 22:16:55 UTC) #3
Sam Clegg
https://codereview.chromium.org/664383004/diff/20001/build/linux/install-arm-sysroot.py File build/linux/install-arm-sysroot.py (right): https://codereview.chromium.org/664383004/diff/20001/build/linux/install-arm-sysroot.py#newcode12 build/linux/install-arm-sysroot.py:12: sys.stderr.write(msg) On 2014/10/21 22:16:55, Lei Zhang wrote: > On ...
6 years, 2 months ago (2014-10-21 22:41:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664383004/80001
6 years, 2 months ago (2014-10-21 22:49:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/14901) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/14863) android_dbg_tests_recipe ...
6 years, 2 months ago (2014-10-21 23:02:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664383004/100001
6 years, 2 months ago (2014-10-21 23:08:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/19108)
6 years, 2 months ago (2014-10-21 23:20:15 UTC) #14
Sam Clegg
+torne for webview_licenses.py
6 years, 2 months ago (2014-10-22 17:26:49 UTC) #16
Torne
webview_licenses LGTM
6 years, 2 months ago (2014-10-22 17:28:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664383004/100001
6 years, 2 months ago (2014-10-22 17:32:49 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/19298) linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/3713) linux_chromium_rel ...
6 years, 2 months ago (2014-10-22 17:44:22 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664383004/100001
6 years, 2 months ago (2014-10-22 18:07:29 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/19313) linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/3739) linux_chromium_rel ...
6 years, 2 months ago (2014-10-22 18:19:19 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664383004/100001
6 years, 2 months ago (2014-10-22 19:45:04 UTC) #27
commit-bot: I haz the power
Committed patchset #5 (id:100001)
6 years, 2 months ago (2014-10-22 20:39:43 UTC) #28
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 20:40:30 UTC) #29
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/41d0e08a38f6cc0cb32a2596953a7262c4a9ab02
Cr-Commit-Position: refs/heads/master@{#300746}

Powered by Google App Engine
This is Rietveld 408576698