Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: PRESUBMIT.py

Issue 664373003: Introduce OS_NACL_SFI and OS_NACL_NONSFI macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/build_config.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 'OS_ANDROID', 258 'OS_ANDROID',
259 'OS_ANDROID_HOST', 259 'OS_ANDROID_HOST',
260 'OS_BSD', 260 'OS_BSD',
261 'OS_CAT', # For testing. 261 'OS_CAT', # For testing.
262 'OS_CHROMEOS', 262 'OS_CHROMEOS',
263 'OS_FREEBSD', 263 'OS_FREEBSD',
264 'OS_IOS', 264 'OS_IOS',
265 'OS_LINUX', 265 'OS_LINUX',
266 'OS_MACOSX', 266 'OS_MACOSX',
267 'OS_NACL', 267 'OS_NACL',
268 'OS_NACL_NONSFI',
269 'OS_NACL_SFI',
268 'OS_OPENBSD', 270 'OS_OPENBSD',
269 'OS_POSIX', 271 'OS_POSIX',
270 'OS_QNX', 272 'OS_QNX',
271 'OS_SOLARIS', 273 'OS_SOLARIS',
272 'OS_WIN', 274 'OS_WIN',
273 ) 275 )
274 276
275 277
276 def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api): 278 def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):
277 """Attempts to prevent use of functions intended only for testing in 279 """Attempts to prevent use of functions intended only for testing in
(...skipping 1461 matching lines...) Expand 10 before | Expand all | Expand 10 after
1739 builders.extend(['cros_x86']) 1741 builders.extend(['cros_x86'])
1740 1742
1741 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1743 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1742 # unless they're .gyp(i) files as changes to those files can break the gyp 1744 # unless they're .gyp(i) files as changes to those files can break the gyp
1743 # step on that bot. 1745 # step on that bot.
1744 if (not all(re.search('^chrome', f) for f in files) or 1746 if (not all(re.search('^chrome', f) for f in files) or
1745 any(re.search('\.gypi?$', f) for f in files)): 1747 any(re.search('\.gypi?$', f) for f in files)):
1746 builders.extend(['android_aosp']) 1748 builders.extend(['android_aosp'])
1747 1749
1748 return GetDefaultTryConfigs(builders) 1750 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | build/build_config.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698