Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: src/heap-snapshot-generator.cc

Issue 664333003: Add remaining @@toStringTag symbols to builtins (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Make heap-snapshot-generator not explode Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/collection-iterator.js ('k') | src/json.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/heap-snapshot-generator-inl.h" 7 #include "src/heap-snapshot-generator-inl.h"
8 8
9 #include "src/allocation-tracker.h" 9 #include "src/allocation-tracker.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1693 matching lines...) Expand 10 before | Expand all | Expand 10 after
1704 } 1704 }
1705 } 1705 }
1706 1706
1707 1707
1708 bool V8HeapExplorer::ExtractAccessorPairProperty( 1708 bool V8HeapExplorer::ExtractAccessorPairProperty(
1709 JSObject* js_obj, int entry, Object* key, Object* callback_obj) { 1709 JSObject* js_obj, int entry, Object* key, Object* callback_obj) {
1710 if (!callback_obj->IsAccessorPair()) return false; 1710 if (!callback_obj->IsAccessorPair()) return false;
1711 AccessorPair* accessors = AccessorPair::cast(callback_obj); 1711 AccessorPair* accessors = AccessorPair::cast(callback_obj);
1712 Object* getter = accessors->getter(); 1712 Object* getter = accessors->getter();
1713 if (!getter->IsOddball()) { 1713 if (!getter->IsOddball()) {
1714 SetPropertyReference(js_obj, entry, String::cast(key), getter, "get %s"); 1714 SetPropertyReference(js_obj, entry, Name::cast(key), getter, "get %s");
1715 } 1715 }
1716 Object* setter = accessors->setter(); 1716 Object* setter = accessors->setter();
1717 if (!setter->IsOddball()) { 1717 if (!setter->IsOddball()) {
1718 SetPropertyReference(js_obj, entry, String::cast(key), setter, "set %s"); 1718 SetPropertyReference(js_obj, entry, Name::cast(key), setter, "set %s");
1719 } 1719 }
1720 return true; 1720 return true;
1721 } 1721 }
1722 1722
1723 1723
1724 void V8HeapExplorer::ExtractElementReferences(JSObject* js_obj, int entry) { 1724 void V8HeapExplorer::ExtractElementReferences(JSObject* js_obj, int entry) {
1725 if (js_obj->HasFastObjectElements()) { 1725 if (js_obj->HasFastObjectElements()) {
1726 FixedArray* elements = FixedArray::cast(js_obj->elements()); 1726 FixedArray* elements = FixedArray::cast(js_obj->elements());
1727 int length = js_obj->IsJSArray() ? 1727 int length = js_obj->IsJSArray() ?
1728 Smi::cast(JSArray::cast(js_obj)->length())->value() : 1728 Smi::cast(JSArray::cast(js_obj)->length())->value() :
(...skipping 1411 matching lines...) Expand 10 before | Expand all | Expand 10 after
3140 writer_->AddString("\"<dummy>\""); 3140 writer_->AddString("\"<dummy>\"");
3141 for (int i = 1; i < sorted_strings.length(); ++i) { 3141 for (int i = 1; i < sorted_strings.length(); ++i) {
3142 writer_->AddCharacter(','); 3142 writer_->AddCharacter(',');
3143 SerializeString(sorted_strings[i]); 3143 SerializeString(sorted_strings[i]);
3144 if (writer_->aborted()) return; 3144 if (writer_->aborted()) return;
3145 } 3145 }
3146 } 3146 }
3147 3147
3148 3148
3149 } } // namespace v8::internal 3149 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/collection-iterator.js ('k') | src/json.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698