Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 664333002: Revert "Added incident report for variations seed signature mismatch." (Closed)

Created:
6 years, 2 months ago by grt (UTC plus 2)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, grt+watch_chromium.org, Ilya Sherman, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Added incident report for variations seed signature mismatch." > Added incident report for variations seed signature mismatch. > > - Keep record of a bad signature in VariationsSeedStore::LoadSeed. > - Register VerifyVariationsSeedSignature in SafeBrowsingService::RegisterAllDelayedAnalysis to send an incident report, if a bad signature is encountered. > > BUG=423467 > > Review URL: https://codereview.chromium.org/646733002 > > Cr-Commit-Position: refs/heads/master@{#299964} This reverts commit 37907039f034c6e39c2590fcfb49b7ce05a8b569 because it accesses g_browser_process->variations_service() off of the main thread, leading to a DCHECK. BUG=423467 TBR=grt@chromium.org Committed: https://crrev.com/1a35a28cc78e9646a649c90db606d919633709d4 Cr-Commit-Position: refs/heads/master@{#300479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -284 lines) Patch
M chrome/browser/metrics/variations/variations_seed_store.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/metrics/variations/variations_seed_store.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/metrics/variations/variations_seed_store_unittest.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc View 5 chunks +3 lines, -13 lines 0 comments Download
D chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident_handlers.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident_handlers.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident_handlers_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/safe_browsing/csd.proto View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664333002/1
6 years, 2 months ago (2014-10-21 11:46:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 13:07:02 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 13:10:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a35a28cc78e9646a649c90db606d919633709d4
Cr-Commit-Position: refs/heads/master@{#300479}

Powered by Google App Engine
This is Rietveld 408576698