Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 664313004: SupervisedUserService cleanup: remove some dead code. (Closed)

Created:
6 years, 2 months ago by Marc Treib
Modified:
6 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

SupervisedUserService cleanup: remove some dead code. Also update some tests accordingly. BUG= Committed: https://crrev.com/418313cf98e6a763ca3d10ffa1f5fc6e198a6f19 Cr-Commit-Position: refs/heads/master@{#300650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -125 lines) Patch
M chrome/browser/supervised_user/supervised_user_browsertest.cc View 4 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.h View 2 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_unittest.cc View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Marc Treib
PTAL!
6 years, 2 months ago (2014-10-21 17:27:29 UTC) #2
Bernhard Bauer
lgtm
6 years, 2 months ago (2014-10-21 18:18:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664313004/1
6 years, 2 months ago (2014-10-22 07:48:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 08:41:41 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 08:42:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/418313cf98e6a763ca3d10ffa1f5fc6e198a6f19
Cr-Commit-Position: refs/heads/master@{#300650}

Powered by Google App Engine
This is Rietveld 408576698