Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 664303002: Fix proprietary codecs builds for GN. (Closed)

Created:
6 years, 2 months ago by DaleCurtis
Modified:
6 years, 2 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix proprietary codecs builds for GN. BUG=none TEST=mojo plays mp3s. Committed: https://crrev.com/cede870bcc0e176edf2eebb8d379561005ce0420 Cr-Commit-Position: refs/heads/master@{#300738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M media/BUILD.gn View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
DaleCurtis
6 years, 2 months ago (2014-10-21 00:24:45 UTC) #2
xhwang
lgtm
6 years, 2 months ago (2014-10-22 16:33:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664303002/1
6 years, 2 months ago (2014-10-22 17:54:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/5371)
6 years, 2 months ago (2014-10-22 19:09:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664303002/1
6 years, 2 months ago (2014-10-22 19:14:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 20:19:46 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 20:21:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cede870bcc0e176edf2eebb8d379561005ce0420
Cr-Commit-Position: refs/heads/master@{#300738}

Powered by Google App Engine
This is Rietveld 408576698