Refactor minidump test utilities for MinidumpWritable, …

minidump/minidump_module_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "minidump/minidump_module_writer.h"
 
 #include <dbghelp.h>
 #include <stdint.h>
 #include <string.h>
 
 #include "base/strings/utf_string_conversions.h"
 #include "gtest/gtest.h"
 #include "minidump/minidump_extensions.h"
 #include "minidump/minidump_file_writer.h"
 #include "minidump/test/minidump_file_writer_test_util.h"
+#include "minidump/test/minidump_string_writer_test_util.h"
 #include "util/file/string_file_writer.h"
 #include "util/misc/uuid.h"
 
 namespace crashpad {
 namespace test {
 namespace {
 
 void GetModuleListStream(const std::string& file_contents,
                          const MINIDUMP_MODULE_LIST** module_list) {
   const size_t kDirectoryOffset = sizeof(MINIDUMP_HEADER);
   const size_t kModuleListStreamOffset =
       kDirectoryOffset + sizeof(MINIDUMP_DIRECTORY);
   const size_t kModulesOffset =
       kModuleListStreamOffset + sizeof(MINIDUMP_MODULE_LIST);
 
   ASSERT_GE(file_contents.size(), kModulesOffset);
 
+  const MINIDUMP_DIRECTORY* directory;
   const MINIDUMP_HEADER* header =
-      reinterpret_cast<const MINIDUMP_HEADER*>(&file_contents[0]);
+      MinidumpHeaderAtStart(file_contents, &directory);
+  ASSERT_NO_FATAL_FAILURE(VerifyMinidumpHeader(header, 1, 0));
+  ASSERT_TRUE(directory);
 
-  ASSERT_NO_FATAL_FAILURE(VerifyMinidumpHeader(header, 1, 0));
-
-  const MINIDUMP_DIRECTORY* directory =
-      reinterpret_cast<const MINIDUMP_DIRECTORY*>(
-          &file_contents[kDirectoryOffset]);
-
-  ASSERT_EQ(kMinidumpStreamTypeModuleList, directory->StreamType);
-  ASSERT_GE(directory->Location.DataSize, sizeof(MINIDUMP_MODULE_LIST));
-  ASSERT_EQ(kModuleListStreamOffset, directory->Location.Rva);
+  ASSERT_EQ(kMinidumpStreamTypeModuleList, directory[0].StreamType);
+  ASSERT_GE(directory[0].Location.DataSize, sizeof(MINIDUMP_MODULE_LIST));
+  ASSERT_EQ(kModuleListStreamOffset, directory[0].Location.Rva);
 
   *module_list = reinterpret_cast<const MINIDUMP_MODULE_LIST*>(
       &file_contents[kModuleListStreamOffset]);
 
   ASSERT_EQ(sizeof(MINIDUMP_MODULE_LIST) +
                 (*module_list)->NumberOfModules * sizeof(MINIDUMP_MODULE),
-            directory->Location.DataSize);
+            directory[0].Location.DataSize);
 }
 
 TEST(MinidumpModuleWriter, EmptyModuleList) {
   MinidumpFileWriter minidump_file_writer;
   MinidumpModuleListWriter module_list_writer;
 
   minidump_file_writer.AddStream(&module_list_writer);
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
@@ skipping 177 matching lines @@
   EXPECT_EQ(expected->VersionInfo.dwFileSubtype,
             observed->VersionInfo.dwFileSubtype);
   EXPECT_EQ(expected->VersionInfo.dwFileDateMS,
             observed->VersionInfo.dwFileDateMS);
   EXPECT_EQ(expected->VersionInfo.dwFileDateLS,
             observed->VersionInfo.dwFileDateLS);
   EXPECT_EQ(0u, observed->Reserved0);
   EXPECT_EQ(0u, observed->Reserved1);
 
   EXPECT_NE(0u, observed->ModuleNameRva);
-  ASSERT_LE(observed->ModuleNameRva,
-            file_contents.size() - sizeof(MINIDUMP_STRING));
-  const MINIDUMP_STRING* module_name = reinterpret_cast<const MINIDUMP_STRING*>(
-      &file_contents[observed->ModuleNameRva]);
-  ASSERT_LE(observed->ModuleNameRva + sizeof(MINIDUMP_STRING) +
-                (module_name->Length + 1),
-            file_contents.size());
-  ASSERT_EQ(0u, module_name->Length % 2);
-  string16 observed_module_name_utf16(
-      reinterpret_cast<const char16*>(
-          &file_contents[observed->ModuleNameRva + sizeof(MINIDUMP_STRING)]),
-      module_name->Length / 2);
+  string16 observed_module_name_utf16 =
+      MinidumpStringAtRVAAsString(file_contents, observed->ModuleNameRva);
   string16 expected_module_name_utf16 = base::UTF8ToUTF16(expected_module_name);
   EXPECT_EQ(expected_module_name_utf16, observed_module_name_utf16);
 
   ASSERT_NO_FATAL_FAILURE(ExpectCodeViewRecord(&observed->CvRecord,
                                                file_contents,
                                                expected_pdb_name,
                                                expected_pdb_uuid,
                                                expected_pdb_timestamp,
                                                expected_pdb_age));
 
@@ skipping 348 matching lines @@
   module_list_writer.AddModule(&module_writer);
   minidump_file_writer.AddStream(&module_list_writer);
 
   StringFileWriter file_writer;
   ASSERT_DEATH(minidump_file_writer.WriteEverything(&file_writer), "name_");
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad