Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 664283002: Refactor minidump test utilities for MinidumpWritable, … (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Refactor minidump test utilities for MinidumpWritable, MinidumpFileWriter, and Minidump*StringWriter. TEST=minidump_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8a6a4c68e44c1aa1e5c4e513a4a75da72bf1e134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+499 lines, -201 lines) Patch
M minidump/minidump.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M minidump/minidump_crashpad_info_writer_test.cc View 2 chunks +16 lines, -19 lines 0 comments Download
M minidump/minidump_exception_writer_test.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M minidump/minidump_file_writer_test.cc View 4 chunks +18 lines, -26 lines 0 comments Download
M minidump/minidump_memory_writer_test.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M minidump/minidump_misc_info_writer_test.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M minidump/minidump_module_writer_test.cc View 3 chunks +10 lines, -22 lines 0 comments Download
M minidump/minidump_simple_string_dictionary_writer_test.cc View 4 chunks +24 lines, -12 lines 0 comments Download
M minidump/minidump_string_writer_test.cc View 6 chunks +33 lines, -39 lines 0 comments Download
M minidump/minidump_system_info_writer_test.cc View 2 chunks +9 lines, -12 lines 0 comments Download
M minidump/minidump_thread_writer_test.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M minidump/test/minidump_file_writer_test_util.h View 1 chunk +21 lines, -0 lines 0 comments Download
M minidump/test/minidump_file_writer_test_util.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M minidump/test/minidump_string_writer_test_util.h View 1 chunk +68 lines, -13 lines 0 comments Download
M minidump/test/minidump_string_writer_test_util.cc View 1 chunk +72 lines, -23 lines 0 comments Download
A minidump/test/minidump_writable_test_util.h View 1 chunk +108 lines, -0 lines 0 comments Download
A minidump/test/minidump_writable_test_util.cc View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
This is the beginning of a refactoring that’s substantial enough to show what the overall ...
6 years, 2 months ago (2014-10-20 22:46:25 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-21 18:06:56 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-21 18:15:12 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8a6a4c68e44c1aa1e5c4e513a4a75da72bf1e134 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698