Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: test/errors/file_cycle0.gyp

Issue 664253005: Simplify and optimize FindCycles (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/errors/dependency_cycle.gyp ('k') | test/errors/file_cycle1.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/errors/file_cycle0.gyp
diff --git a/test/variables/commands/repeated_multidir/main.gyp b/test/errors/file_cycle0.gyp
similarity index 59%
copy from test/variables/commands/repeated_multidir/main.gyp
copy to test/errors/file_cycle0.gyp
index 5beeeb7244d2e9f95f01c35d506d62b4afa5ad09..3bfafb6cb393781e848ce737545c6e3cf9fccde3 100644
--- a/test/variables/commands/repeated_multidir/main.gyp
+++ b/test/errors/file_cycle0.gyp
@@ -5,12 +5,13 @@
{
'targets': [
{
- 'target_name': 'main',
+ 'target_name': 'top',
+ 'type': 'none',
+ 'dependencies': [ 'file_cycle1.gyp:middle' ],
+ },
+ {
+ 'target_name': 'bottom',
'type': 'none',
- 'dependencies': [
- 'dir_1/test_1.gyp:target_1',
- 'dir_2/test_2.gyp:target_2',
- ],
},
],
}
« no previous file with comments | « test/errors/dependency_cycle.gyp ('k') | test/errors/file_cycle1.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698