Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 664243003: Make AndroidWebView shell init data reduction proxy from commandline (Closed)

Created:
6 years, 2 months ago by hush (inactive)
Modified:
6 years, 2 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make AndroidWebView shell init data reduction proxy from commandline To enable data reduction proxy on the commandline, you need: build/android/adb_android_webview_command_line --enable-spdy-proxy-auth --spdy-proxy-auth-value=[your real key] BUG= Committed: https://crrev.com/ffe2c7a61d7f07ee772f7d09d0c04658d350eef1 Cr-Commit-Position: refs/heads/master@{#300622}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java View 1 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
hush (inactive)
It depends on https://codereview.chromium.org/651443005/ otherwise you will see crashes.
6 years, 2 months ago (2014-10-21 03:04:08 UTC) #2
sgurun-gerrit only
lgtm https://codereview.chromium.org/664243003/diff/20001/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java File android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java (right): https://codereview.chromium.org/664243003/diff/20001/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java#newcode100 android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java:100: nit: drop empty line
6 years, 2 months ago (2014-10-22 00:33:12 UTC) #5
hush (inactive)
On 2014/10/22 00:33:12, sgurun wrote: > lgtm > > https://codereview.chromium.org/664243003/diff/20001/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java > File > android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java > ...
6 years, 2 months ago (2014-10-22 00:49:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664243003/60001
6 years, 2 months ago (2014-10-22 00:52:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664243003/60001
6 years, 2 months ago (2014-10-22 02:03:45 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years, 2 months ago (2014-10-22 02:28:07 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:05:31 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ffe2c7a61d7f07ee772f7d09d0c04658d350eef1
Cr-Commit-Position: refs/heads/master@{#300622}

Powered by Google App Engine
This is Rietveld 408576698