Issue 664233002: Roll dom_distiller_js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 664233002: Roll dom_distiller_js (Closed)

Created:
6 years, 2 months ago by dcheng

Modified:
6 years, 2 months ago

Reviewers:
cjhopman

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Roll dom_distiller_js Pick up the changes to use scoped_ptr<T>::Pass() instead of PassAs(). BUG=423621 Committed: https://crrev.com/8d99a849eb62b28859ffe13d0d937aeef3321c51 Cr-Commit-Position: refs/heads/master@{#300362}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+523 lines, -520 lines)			Patch
M	third_party/dom_distiller_js/README.chromium	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/dom_distiller_js/package/js/domdistiller.js	View	1 chunk	+512 lines, -509 lines	0 comments	Download
M	third_party/dom_distiller_js/package/proto_gen/third_party/dom_distiller_js/dom_distiller_json_converter.h	View	10 chunks	+10 lines, -10 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664233002/1

6 years, 2 months ago (2014-10-20 21:56:58 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-20 22:42:24 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8d99a849eb62b28859ffe13d0d937aeef3321c51
Cr-Commit-Position: refs/heads/master@{#300362}