chrome/browser/ui/views/find_bar_host.cc - Issue 664223002: MacViews: Get views based FindBar to compile on the Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/find_bar_host.cc

Issue 664223002: MacViews: Get views based FindBar to compile on the Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolve duplicate basename Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/find_bar/find_bar_view_cocoa.h ('K') | « chrome/browser/ui/views/find_bar_host.h ('k') | chrome/browser/ui/views/find_bar_host_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/find_bar_host.cc

diff --git a/chrome/browser/ui/views/find_bar_host.cc b/chrome/browser/ui/views/find_bar_host.cc

index cdec6d827671889443ce4be7aeeb8c39893b1c0d..36604228e7fc3750f0d461d2629c898f623d2907 100644

--- a/chrome/browser/ui/views/find_bar_host.cc

+++ b/chrome/browser/ui/views/find_bar_host.cc

@@ -46,11 +46,6 @@ FindBarHost::~FindBarHost() {

bool FindBarHost::MaybeForwardKeyEventToWebpage(

const ui::KeyEvent& key_event) {

- if (!ShouldForwardKeyEventToWebpageNative(key_event)) {

- // Native implementation says not to forward these events.

- return false;

- }

switch (key_event.key_code()) {

case ui::VKEY_DOWN:

case ui::VKEY_UP:

@@ -161,6 +156,12 @@ void FindBarHost::UpdateUIForFindResult(const FindNotificationDetails& result,

ResetFocusTracker();

}

+void FindBarHost::AudibleAlert() {

+#if defined(OS_WIN)

+ MessageBeep(MB_OK);

+#endif

bool FindBarHost::IsFindBarVisible() {

return DropdownBarHost::IsVisible();

}