MacViews: Get views based FindBar to compile on the Mac.

MacViews: Get views based FindBar to compile on the Mac.

Building for MacViews was missing the symbols defined in find_bar_host_aura.cc.
Merge find_bar_host_aura.cc to find_bar_host.cc.
Delete no longer used ShouldForwardKeyEventToWebpageNative.
Rename find_bar_view.mm to avoid duplicate basename conflict with find_bar_view.cc.

BUG=425229
Committed: https://crrev.com/af36b4e8bbce58f478ebe4d008ec4514f0d1f6fc
Cr-Commit-Position: refs/heads/master@{#300762}

[Andre, 2014-10-20 21:10:41]

Patchset #1 (id:1) has been deleted

[Andre, 2014-10-20 22:17:06]

andresantoso@chromium.org changed reviewers:
+ msw@chromium.org, rsesek@chromium.org

[Andre, 2014-10-20 22:17:06]

msw@, PTAL for c/b/ui/views.
rsesek@, PTAL for c/b/ui/cocoa.

[Robert Sesek, 2014-10-20 22:18:33]

cocoa/ LGTM % comment

https://codereview.chromium.org/664223002/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/find_bar/find_bar_view_cocoa.h (right):

https://codereview.chromium.org/664223002/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/find_bar/find_bar_view_cocoa.h:6: #define
CHROME_BROWSER_UI_COCOA_FIND_BAR_FIND_BAR_VIEW_H_
Update guards.

[Andre, 2014-10-20 22:22:51]

https://codereview.chromium.org/664223002/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/find_bar/find_bar_view_cocoa.h (right):

https://codereview.chromium.org/664223002/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/find_bar/find_bar_view_cocoa.h:6: #define
CHROME_BROWSER_UI_COCOA_FIND_BAR_FIND_BAR_VIEW_H_
On 2014/10/20 22:18:32, Robert Sesek wrote:
> Update guards.

Done.

[Robert Sesek, 2014-10-20 22:34:05]

Please hold off on landing until discussion on
https://codereview.chromium.org/657443004/ is resolved.

[msw, 2014-10-22 19:34:24]

c/b/ui/views and the gypi lgtm pending Robert's hold.

[Robert Sesek, 2014-10-22 19:45:35]

LGTM

[Andre, 2014-10-22 19:48:05]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2014-10-22 19:50:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664223002/60001

[commit-bot: I haz the power, 2014-10-22 21:23:53]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2014-10-22 21:25:08]

Patchset 3 (id:??) landed as
https://crrev.com/af36b4e8bbce58f478ebe4d008ec4514f0d1f6fc
Cr-Commit-Position: refs/heads/master@{#300762}