Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 664173003: Remove a pointless use of SkWeakRefCnt. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove a pointless use of SkWeakRefCnt. Can't quite get rid of SkWeakRefCnt yet... SkFontMgr_indirect uses it to cache SkTypefaces, and I don't quite understand it enough yet to cut out the weak refs. BUG=skia:3065 Committed: https://skia.googlesource.com/skia/+/60b6e9dbbc492f987a5b887dff60aec107ab70d0

Patch Set 1 #

Patch Set 2 : missed #

Patch Set 3 : missed also #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -44 lines) Patch
M src/core/SkTypefaceCache.h View 3 chunks +2 lines, -5 lines 0 comments Download
M src/core/SkTypefaceCache.cpp View 4 chunks +8 lines, -34 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontMgr_win_dw.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
mtklein
6 years, 1 month ago (2014-10-24 15:16:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664173003/1
6 years, 1 month ago (2014-10-24 15:16:50 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-24 15:16:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/230) Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/228)
6 years, 1 month ago (2014-10-24 15:18:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664173003/20001
6 years, 1 month ago (2014-10-24 15:20:53 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-24 15:20:54 UTC) #10
bungeman-skia
lgtm
6 years, 1 month ago (2014-10-24 15:51:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/241)
6 years, 1 month ago (2014-10-24 17:14:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664173003/40001
6 years, 1 month ago (2014-10-24 17:34:46 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 17:43:28 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 60b6e9dbbc492f987a5b887dff60aec107ab70d0

Powered by Google App Engine
This is Rietveld 408576698