Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: cc/layers/ui_resource_layer_unittest.cc

Issue 664173002: Prevent recreation of UI resource holder when created with resource ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added unit test, going back to patch #5 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/layers/ui_resource_layer.cc ('K') | « cc/layers/ui_resource_layer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/ui_resource_layer_unittest.cc
diff --git a/cc/layers/ui_resource_layer_unittest.cc b/cc/layers/ui_resource_layer_unittest.cc
index 09d57a96520de55b498ce908fe2aa487af38e858..3855c6c6d5fcb282c4568026d705d6c9b607765d 100644
--- a/cc/layers/ui_resource_layer_unittest.cc
+++ b/cc/layers/ui_resource_layer_unittest.cc
@@ -102,6 +102,14 @@ TEST_F(UIResourceLayerTest, SetUIResourceId) {
test_layer->Update(&queue, &occlusion_tracker);
EXPECT_TRUE(test_layer->DrawsContent());
+
+ // ID is preserved even when you set ID first and attach it to the tree.
+ scoped_refptr<UIResourceLayer> new_test_layer = UIResourceLayer::Create();
+ scoped_ptr<ScopedUIResource> new_resource = ScopedUIResource::Create(
+ layer_tree_host_.get(), UIResourceBitmap(gfx::Size(5, 5), is_opaque));
+ new_test_layer->SetUIResourceId(new_resource->id());
+ test_layer->AddChild(new_test_layer);
+ EXPECT_EQ(new_resource->id(), new_test_layer->GetUIResourceId());
}
} // namespace
« cc/layers/ui_resource_layer.cc ('K') | « cc/layers/ui_resource_layer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698