Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: cc/layers/ui_resource_layer.cc

Issue 664173002: Prevent recreation of UI resource holder when created with resource ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed NeedsRecreation Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/layers/ui_resource_layer.h" 5 #include "cc/layers/ui_resource_layer.h"
6 6
7 #include "cc/layers/ui_resource_layer_impl.h" 7 #include "cc/layers/ui_resource_layer_impl.h"
8 #include "cc/resources/prioritized_resource.h" 8 #include "cc/resources/prioritized_resource.h"
9 #include "cc/resources/resource_update.h" 9 #include "cc/resources/resource_update.h"
10 #include "cc/resources/resource_update_queue.h" 10 #include "cc/resources/resource_update_queue.h"
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 vertex_opacity_[3] = bottom_right; 100 vertex_opacity_[3] = bottom_right;
101 SetNeedsCommit(); 101 SetNeedsCommit();
102 } 102 }
103 103
104 void UIResourceLayer::SetLayerTreeHost(LayerTreeHost* host) { 104 void UIResourceLayer::SetLayerTreeHost(LayerTreeHost* host) {
105 if (host == layer_tree_host()) 105 if (host == layer_tree_host())
106 return; 106 return;
107 107
108 Layer::SetLayerTreeHost(host); 108 Layer::SetLayerTreeHost(host);
109 109
110 // Recreate the resource hold against the new LTH. 110 // Recreate the resource held against the new LTH.
111 RecreateUIResourceHolder(); 111 RecreateUIResourceHolder();
112 } 112 }
113 113
114 void UIResourceLayer::RecreateUIResourceHolder() { 114 void UIResourceLayer::RecreateUIResourceHolder() {
115 ui_resource_holder_ = nullptr; 115 if (!bitmap_.empty())
116 if (layer_tree_host() && !bitmap_.empty()) { 116 SetBitmap(bitmap_);
117 ui_resource_holder_ =
118 ScopedUIResourceHolder::Create(layer_tree_host(), bitmap_);
119 }
120 UpdateDrawsContent(HasDrawableContent());
121 } 117 }
122 118
123 void UIResourceLayer::SetBitmap(const SkBitmap& skbitmap) { 119 void UIResourceLayer::SetBitmap(const SkBitmap& skbitmap) {
124 bitmap_ = skbitmap; 120 bitmap_ = skbitmap;
125 121 if (layer_tree_host() && !bitmap_.empty()) {
126 RecreateUIResourceHolder(); 122 ui_resource_holder_ =
123 ScopedUIResourceHolder::Create(layer_tree_host(), bitmap_);
124 } else {
125 ui_resource_holder_ = nullptr;
126 }
127 UpdateDrawsContent(HasDrawableContent());
127 SetNeedsCommit(); 128 SetNeedsCommit();
128 } 129 }
129 130
130 void UIResourceLayer::SetUIResourceId(UIResourceId resource_id) { 131 void UIResourceLayer::SetUIResourceId(UIResourceId resource_id) {
131 if (ui_resource_holder_ && ui_resource_holder_->id() == resource_id) 132 if (ui_resource_holder_ && ui_resource_holder_->id() == resource_id)
132 return; 133 return;
133 134
134 if (resource_id) 135 if (resource_id)
135 ui_resource_holder_ = SharedUIResourceHolder::Create(resource_id); 136 ui_resource_holder_ = SharedUIResourceHolder::Create(resource_id);
136 else 137 else
(...skipping 20 matching lines...) Expand all
157 gfx::Size image_size = 158 gfx::Size image_size =
158 layer_tree_host()->GetUIResourceSize(ui_resource_holder_->id()); 159 layer_tree_host()->GetUIResourceSize(ui_resource_holder_->id());
159 layer_impl->SetUIResourceId(ui_resource_holder_->id()); 160 layer_impl->SetUIResourceId(ui_resource_holder_->id());
160 layer_impl->SetImageBounds(image_size); 161 layer_impl->SetImageBounds(image_size);
161 layer_impl->SetUV(uv_top_left_, uv_bottom_right_); 162 layer_impl->SetUV(uv_top_left_, uv_bottom_right_);
162 layer_impl->SetVertexOpacity(vertex_opacity_); 163 layer_impl->SetVertexOpacity(vertex_opacity_);
163 } 164 }
164 } 165 }
165 166
166 } // namespace cc 167 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698