Issue 664163004: -Go bindings for creating/managing shared buffers between applications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 664163004: -Go bindings for creating/managing shared buffers between applications (Closed)

Created:
6 years, 1 month ago by gauthamt

Modified:
6 years, 1 month ago

Reviewers:
asadovsky, viettrungluu

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

-Go bindings for creating/managing shared buffers between applications -Added test for these bindings. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e083961bf11fd0c94d40be8853761da529b6d444

Patch Set 1 #

Patch Set 2 : Fix comments. #

Patch Set 3 : Go build patches #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+146 lines, -5 lines)			Patch
M	build/go/rules.gni	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	mojo/go/tests/system_test.go	View		2 chunks	+47 lines, -1 line	0 comments	Download
M	mojo/public/go/system/core.go	View	1	2 chunks	+18 lines, -0 lines	0 comments	Download
M	mojo/public/go/system/impl/core_impl.go	View		2 chunks	+26 lines, -0 lines	0 comments	Download
M	mojo/public/go/system/impl/mojo_types.go	View	1	4 chunks	+52 lines, -0 lines	0 comments	Download
M	third_party/libevent/BUILD.gn	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/modp_b64/BUILD.gn	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

gauthamt

6 years, 1 month ago (2014-10-27 19:47:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
e083961bf11fd0c94d40be8853761da529b6d444 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages