Use embedded sign in UI for inline sign in flow

Use embedded sign in UI for inline sign in flow

BUG=315259
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234093

[guohui, 2013-11-08 15:22:04]

Hey,

could you please take a look at the CL?

Thanks,

Hui

[xiyuan, 2013-11-08 18:19:56]

https://codereview.chromium.org/66403006/diff/40001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth/main.js (right):

https://codereview.chromium.org/66403006/diff/40001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:84: url += '&service=' +
encodeURIComponent(this.service_) +
The "&" before service might be not needed for embedded signin path. We probably
should check if there is "?" and if there are params after "?" to decide whether
this "&" is needed.

Beyond this, I wonder if we have a better way to form the url here with so many
uncertain pieces.

[guohui, 2013-11-08 18:59:36]

https://codereview.chromium.org/66403006/diff/40001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth/main.js (right):

https://codereview.chromium.org/66403006/diff/40001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:84: url += '&service=' +
encodeURIComponent(this.service_) +
On 2013/11/08 18:19:57, xiyuan wrote:
> The "&" before service might be not needed for embedded signin path. We
probably
> should check if there is "?" and if there are params after "?" to decide
whether
> this "&" is needed.
> 
> Beyond this, I wonder if we have a better way to form the url here with so
many
> uncertain pieces.

Done.

[xiyuan, 2013-11-08 19:03:14]

lgtm

[commit-bot: I haz the power, 2013-11-08 19:14:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/66403006/170001

[commit-bot: I haz the power, 2013-11-08 19:35:36]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[guohui, 2013-11-08 19:39:32]

+sky owner review for
chrome/browser/ui/views/profile_chooser_view.cc

[Roger Tawa OOO till Jul 10th, 2013-11-08 19:49:19]

lgtm

[sky, 2013-11-08 21:00:00]

LGTM

[commit-bot: I haz the power, 2013-11-08 21:02:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/66403006/300001

[commit-bot: I haz the power, 2013-11-09 04:41:37]

Change committed as 234093