Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 663913003: Remove content from public_headers.gypi (Closed)

Created:
6 years, 2 months ago by scroggo
Modified:
6 years, 2 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove content from public_headers. The file is unused, but we cannot safely delete it until we remove the reference in a chromium gyp file. BUG=skia:2350 Committed: https://skia.googlesource.com/skia/+/84c14ee1073461f3a53e86bea143717310e8f4a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -268 lines) Patch
M gyp/public_headers.gypi View 1 chunk +3 lines, -268 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scroggo
6 years, 2 months ago (2014-10-20 16:39:05 UTC) #2
mtklein
lgtm
6 years, 2 months ago (2014-10-20 16:41:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663913003/1
6 years, 2 months ago (2014-10-20 16:49:12 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 16:55:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 84c14ee1073461f3a53e86bea143717310e8f4a7

Powered by Google App Engine
This is Rietveld 408576698