Put Filter into namespace net.

Put Filter into namespace net.

BUG=64263
TEST=existing unit_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77373

[tfarina, 2011-03-08 20:54:49]

If you are using git, you can do 'git try -r HEAD' so it has a better chance to
pass the update step :)

Some minor comments below. Let me take another look before committing.

http://codereview.chromium.org/6639002/diff/1/net/base/filter.cc
File net/base/filter.cc (right):

http://codereview.chromium.org/6639002/diff/1/net/base/filter.cc#newcode14
net/base/filter.cc:14: namespace net {
Please, could you move this to line 42?

http://codereview.chromium.org/6639002/diff/1/net/base/filter.h
File net/base/filter.h (right):

http://codereview.chromium.org/6639002/diff/1/net/base/filter.h#newcode1
net/base/filter.h:1: // Copyright (c) 2006-2008 The Chromium Authors. All rights
reserved.
please, update the year through all the files you have touched.

http://codereview.chromium.org/6639002/diff/1/net/base/gzip_filter_unittest.cc
File net/base/gzip_filter_unittest.cc (right):

http://codereview.chromium.org/6639002/diff/1/net/base/gzip_filter_unittest.c...
net/base/gzip_filter_unittest.cc:23: namespace net {
please, could you move this to the line 56?

http://codereview.chromium.org/6639002/diff/1/net/url_request/url_request_job...
File net/url_request/url_request_job_tracker_unittest.cc (right):

http://codereview.chromium.org/6639002/diff/1/net/url_request/url_request_job...
net/url_request/url_request_job_tracker_unittest.cc:121:
std::vector<net::Filter::FilterType>* encoding_types) {
Can you try changing this file from anonymous namespace to net namespace (so we
can get rid of this net:: here)? If you can't, I'm fine too.

[adamk, 2011-03-08 21:35:20]

Thanks for the git try tip: will be kicking off another set of jobs with this
new patch.

http://codereview.chromium.org/6639002/diff/1/net/base/filter.cc
File net/base/filter.cc (right):

http://codereview.chromium.org/6639002/diff/1/net/base/filter.cc#newcode14
net/base/filter.cc:14: namespace net {
On 2011/03/08 20:54:49, tfarina wrote:
> Please, could you move this to line 42?

Done.

http://codereview.chromium.org/6639002/diff/1/net/base/filter.h
File net/base/filter.h (right):

http://codereview.chromium.org/6639002/diff/1/net/base/filter.h#newcode1
net/base/filter.h:1: // Copyright (c) 2006-2008 The Chromium Authors. All rights
reserved.
On 2011/03/08 20:54:49, tfarina wrote:
> please, update the year through all the files you have touched.

Done.

http://codereview.chromium.org/6639002/diff/1/net/base/gzip_filter_unittest.cc
File net/base/gzip_filter_unittest.cc (right):

http://codereview.chromium.org/6639002/diff/1/net/base/gzip_filter_unittest.c...
net/base/gzip_filter_unittest.cc:23: namespace net {
On 2011/03/08 20:54:49, tfarina wrote:
> please, could you move this to the line 56?

Done.

http://codereview.chromium.org/6639002/diff/1/net/url_request/url_request_job...
File net/url_request/url_request_job_tracker_unittest.cc (right):

http://codereview.chromium.org/6639002/diff/1/net/url_request/url_request_job...
net/url_request/url_request_job_tracker_unittest.cc:121:
std::vector<net::Filter::FilterType>* encoding_types) {
On 2011/03/08 20:54:49, tfarina wrote:
> Can you try changing this file from anonymous namespace to net namespace (so
we
> can get rid of this net:: here)? If you can't, I'm fine too.

Done.  Note that I put the namespace at the top here, since the anonymous
namespace previously wrapped the entire file and I didn't want to change that.

[tfarina, 2011-03-08 21:41:05]

http://codereview.chromium.org/6639002/diff/8/net/base/filter.h
File net/base/filter.h (right):

http://codereview.chromium.org/6639002/diff/8/net/base/filter.h#newcode1
net/base/filter.h:1: // Copyright (c) 2006-2011 The Chromium Authors. All rights
reserved.
2006-2011 -> 2011

http://codereview.chromium.org/6639002/diff/8/net/base/filter_unittest.cc
File net/base/filter_unittest.cc (right):

http://codereview.chromium.org/6639002/diff/8/net/base/filter_unittest.cc#new...
net/base/filter_unittest.cc:1: // Copyright (c) 2006-2011 The Chromium Authors.
All rights reserved.
That should be just 2011. So 2006-2011 -> 2011.

http://codereview.chromium.org/6639002/diff/8/net/url_request/url_request_job...
File net/url_request/url_request_job_tracker_unittest.cc (right):

http://codereview.chromium.org/6639002/diff/8/net/url_request/url_request_job...
net/url_request/url_request_job_tracker_unittest.cc:28: namespace {
You can get rid of the anonymous namespace (that was my initial suggestion) :)

[adamk, 2011-03-08 21:53:09]

Thanks for the quick review!

http://codereview.chromium.org/6639002/diff/8/net/base/filter.h
File net/base/filter.h (right):

http://codereview.chromium.org/6639002/diff/8/net/base/filter.h#newcode1
net/base/filter.h:1: // Copyright (c) 2006-2011 The Chromium Authors. All rights
reserved.
On 2011/03/08 21:41:05, tfarina wrote:
> 2006-2011 -> 2011

Ok, done. Thanks for pointing this out, I now see it's in the style guide.

http://codereview.chromium.org/6639002/diff/8/net/base/filter_unittest.cc
File net/base/filter_unittest.cc (right):

http://codereview.chromium.org/6639002/diff/8/net/base/filter_unittest.cc#new...
net/base/filter_unittest.cc:1: // Copyright (c) 2006-2011 The Chromium Authors.
All rights reserved.
On 2011/03/08 21:41:05, tfarina wrote:
> That should be just 2011. So 2006-2011 -> 2011.

Done.

http://codereview.chromium.org/6639002/diff/8/net/url_request/url_request_job...
File net/url_request/url_request_job_tracker_unittest.cc (right):

http://codereview.chromium.org/6639002/diff/8/net/url_request/url_request_job...
net/url_request/url_request_job_tracker_unittest.cc:28: namespace {
On 2011/03/08 21:41:05, tfarina wrote:
> You can get rid of the anonymous namespace (that was my initial suggestion) :)

Mind if I keep it?  It's nicely hiding GetResponseBody() and MockJobObserver
(keeping them in file scope), and the latter still benefits from being in the
net namespace.  IMHO, unless they need to be friended, putting test files in an
anonymous namespace is a good way of ensuring their symbols don't collide with
anything.

[tfarina, 2011-03-08 21:58:45]

On 2011/03/08 21:53:09, Adam Klein wrote:
> Mind if I keep it?

Yes, I prefer to do this instead so:

- Make kBasic, kCompressed and GetResponseBody static outside of the namespace
net.
- And everything else wrapped in the namespace net.

See http://codereview.chromium.org/6628020/ for reference.

[tfarina, 2011-03-08 22:24:29]

Per our discussion on irc, LGTM. thanks.