Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/list-inl.h

Issue 663893004: Use memcpy in List::AddAll for fundamental types. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed offline comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/base/macros.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_LIST_INL_H_ 5 #ifndef V8_LIST_INL_H_
6 #define V8_LIST_INL_H_ 6 #define V8_LIST_INL_H_
7 7
8 #include "src/list.h" 8 #include "src/list.h"
9 9
10 #include "src/base/macros.h"
10 #include "src/base/platform/platform.h" 11 #include "src/base/platform/platform.h"
11 12
12 namespace v8 { 13 namespace v8 {
13 namespace internal { 14 namespace internal {
14 15
15 16
16 template<typename T, class P> 17 template<typename T, class P>
17 void List<T, P>::Add(const T& element, P alloc) { 18 void List<T, P>::Add(const T& element, P alloc) {
18 if (length_ < capacity_) { 19 if (length_ < capacity_) {
19 data_[length_++] = element; 20 data_[length_++] = element;
20 } else { 21 } else {
21 List<T, P>::ResizeAdd(element, alloc); 22 List<T, P>::ResizeAdd(element, alloc);
22 } 23 }
23 } 24 }
24 25
25 26
26 template<typename T, class P> 27 template<typename T, class P>
27 void List<T, P>::AddAll(const List<T, P>& other, P alloc) { 28 void List<T, P>::AddAll(const List<T, P>& other, P alloc) {
28 AddAll(other.ToVector(), alloc); 29 AddAll(other.ToVector(), alloc);
29 } 30 }
30 31
31 32
32 template<typename T, class P> 33 template<typename T, class P>
33 void List<T, P>::AddAll(const Vector<T>& other, P alloc) { 34 void List<T, P>::AddAll(const Vector<T>& other, P alloc) {
34 int result_length = length_ + other.length(); 35 int result_length = length_ + other.length();
35 if (capacity_ < result_length) Resize(result_length, alloc); 36 if (capacity_ < result_length) Resize(result_length, alloc);
36 for (int i = 0; i < other.length(); i++) { 37 if (base::is_fundamental<T>()) {
37 data_[length_ + i] = other.at(i); 38 memcpy(data_ + length_, other.start(), sizeof(*data_) * other.length());
39 } else {
40 for (int i = 0; i < other.length(); i++) data_[length_ + i] = other.at(i);
38 } 41 }
39 length_ = result_length; 42 length_ = result_length;
40 } 43 }
41 44
42 45
43 // Use two layers of inlining so that the non-inlined function can 46 // Use two layers of inlining so that the non-inlined function can
44 // use the same implementation as the inlined version. 47 // use the same implementation as the inlined version.
45 template<typename T, class P> 48 template<typename T, class P>
46 void List<T, P>::ResizeAdd(const T& element, P alloc) { 49 void List<T, P>::ResizeAdd(const T& element, P alloc) {
47 ResizeAddInternal(element, alloc); 50 ResizeAddInternal(element, alloc);
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 255
253 template <typename T> 256 template <typename T>
254 int SortedListBSearch(const List<T>& list, T elem) { 257 int SortedListBSearch(const List<T>& list, T elem) {
255 return SortedListBSearch<T, ElementCmp<T> > (list, ElementCmp<T>(elem)); 258 return SortedListBSearch<T, ElementCmp<T> > (list, ElementCmp<T>(elem));
256 } 259 }
257 260
258 261
259 } } // namespace v8::internal 262 } } // namespace v8::internal
260 263
261 #endif // V8_LIST_INL_H_ 264 #endif // V8_LIST_INL_H_
OLDNEW
« no previous file with comments | « src/base/macros.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698