Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 663893004: Use memcpy in List::AddAll for fundamental types. (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
6 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Use memcpy in List::AddAll for fundamental types. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24868

Patch Set 1 #

Total comments: 1

Patch Set 2 : implement replacement for is_fundamental #

Patch Set 3 : add new file #

Patch Set 4 : addressed offline comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M src/base/macros.h View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
M src/list-inl.h View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yang
6 years, 1 month ago (2014-10-24 07:52:18 UTC) #1
Sven Panne
NOT LGTM. https://codereview.chromium.org/663893004/diff/1/src/list-inl.h File src/list-inl.h (right): https://codereview.chromium.org/663893004/diff/1/src/list-inl.h#newcode36 src/list-inl.h:36: if (std::is_fundamental<T>::value) { std:is_fundamental is a C++11 ...
6 years, 1 month ago (2014-10-24 08:04:01 UTC) #2
Yang
On 2014/10/24 08:04:01, Sven Panne wrote: > NOT LGTM. > > https://codereview.chromium.org/663893004/diff/1/src/list-inl.h > File src/list-inl.h ...
6 years, 1 month ago (2014-10-24 08:34:35 UTC) #3
Yang
On 2014/10/24 08:34:35, Yang wrote: > On 2014/10/24 08:04:01, Sven Panne wrote: > > NOT ...
6 years, 1 month ago (2014-10-24 09:55:44 UTC) #4
Sven Panne
lgtm
6 years, 1 month ago (2014-10-24 10:31:00 UTC) #5
Yang
6 years, 1 month ago (2014-10-24 12:34:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 24868 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698