Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 663893002: Clean up forward declarations in Source/web (Closed)

Created:
6 years, 2 months ago by zhaoze.zhou
Modified:
6 years, 2 months ago
CC:
blink-reviews, eustas+blink_chromium.org, caseq+blink_chromium.org, dcheng, loislo+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, philipj_slow, yurys+blink_chromium.org, eric.carlson_apple.com, mkwst+moarreviews_chromium.org, vsevik+blink_chromium.org, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, groby+blinkspell_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, lushnikov+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/web These forward references are not needed anymore. After this patch, Source/web has no unneeded forward references any more. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183958

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -59 lines) Patch
M Source/web/ChromeClientImpl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/web/EditorClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ExternalPopupMenu.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/InspectorClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/LinkHighlight.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/MediaKeysClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/PageOverlay.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/SpellCheckerClientImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/ViewportAnchor.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/web/WebDevToolsAgentPrivate.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.h View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/WebPopupMenuImpl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/WebTextCheckingCompletionImpl.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WorkerPermissionClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
zhaoze.zhou
6 years, 2 months ago (2014-10-17 22:32:45 UTC) #2
zhaoze.zhou
6 years, 2 months ago (2014-10-17 22:32:46 UTC) #3
rwlbuis
On 2014/10/17 22:32:46, zhaoze.zhou wrote: @zhou try another adam, adamk :-)
6 years, 2 months ago (2014-10-17 23:07:02 UTC) #4
Mike West
Bots are happy, and I spot-checked most of the removals. LGTM.
6 years, 2 months ago (2014-10-18 11:58:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663893002/20001
6 years, 2 months ago (2014-10-20 02:46:29 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 02:50:13 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183958

Powered by Google App Engine
This is Rietveld 408576698