Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 663873002: Add the ability to observe MessagePumpMojo (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Add the ability to observe MessagePumpMojo We need the ability to observe the Mojo message pump in order to correctly resolve promises at the end of microtasks triggered by signaling Mojo handles. Another approach James and I discussed for this CL was to trigger MessageLoop::TaskObserver, but that requires a PendingTask, which we don't have. I investigated removing the PendingTask argument from MessageLoop::TaskObserver, but it's used in a number of tests. Instead, this CL follows the approach used by MessagePumpLibevent and introduces a specialized observer interface for the message pump. R=jamesr@chromium.org Committed: https://crrev.com/4ba3cada588332b5e67b326c35dec8a0cc779d45 Cr-Commit-Position: refs/heads/master@{#300169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -0 lines) Patch
M mojo/common/message_pump_mojo.h View 5 chunks +20 lines, -0 lines 0 comments Download
M mojo/common/message_pump_mojo.cc View 5 chunks +22 lines, -0 lines 0 comments Download
M mojo/common/message_pump_mojo_unittest.cc View 2 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
6 years, 2 months ago (2014-10-17 19:12:43 UTC) #1
jamesr
lgtm
6 years, 2 months ago (2014-10-17 19:35:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663873002/1
6 years, 2 months ago (2014-10-17 20:58:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 22:02:38 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 22:04:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ba3cada588332b5e67b326c35dec8a0cc779d45
Cr-Commit-Position: refs/heads/master@{#300169}

Powered by Google App Engine
This is Rietveld 408576698