Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issue 66383003: Renaming isTableElement() to isRenderedTable() as per the FIXME comment. (Closed)

Created:
7 years, 1 month ago by arpitab_
Modified:
7 years, 1 month ago
Reviewers:
yosin_UTC9, ojan
CC:
blink-reviews, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, adamk+blink_chromium.org, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Renaming isTableElement() to isRenderedTable() as per the FIXME comment. Since isTableElement() anyway verifies against the node's renderer, this seems to be a more applicable name. Also, instead of checking against the renderer's display style property (whether it is of type TABLE or INLINE_TABLE), we can simply call on the isTable() method which returns true for all table renderers. No existing tests should fail with this change. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M Source/core/dom/Position.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/PositionIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Caret.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/htmlediting.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/htmlediting.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
arpitab_
7 years, 1 month ago (2013-11-08 11:18:19 UTC) #1
ojan
lgtm
7 years, 1 month ago (2013-11-08 20:30:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/66383003/1
7 years, 1 month ago (2013-11-08 20:31:44 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=2472
7 years, 1 month ago (2013-11-08 21:19:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/66383003/1
7 years, 1 month ago (2013-11-09 00:49:32 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-09 01:32:44 UTC) #6
Message was sent while issue was closed.
Change committed as 161669

Powered by Google App Engine
This is Rietveld 408576698