Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 663823004: Add toyoshim as a per-file owner for Web MIDI (Closed)

Created:
6 years, 2 months ago by Takashi Toyoshima
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add toyoshim as a per-file owner for Web MIDI NOTRY=true Committed: https://crrev.com/fe606306eef3e6e273309c2b84a7dd756fd49621 Cr-Commit-Position: refs/heads/master@{#300325}

Patch Set 1 #

Patch Set 2 : renderer too #

Patch Set 3 : renderer_webmidi* too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/media/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Takashi Toyoshima
Hi, can I have a owner permission for MIDI related files as I do in ...
6 years, 2 months ago (2014-10-18 05:39:09 UTC) #2
scherkus (not reviewing)
lgtm
6 years, 2 months ago (2014-10-20 20:37:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663823004/40001
6 years, 2 months ago (2014-10-20 20:39:08 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-20 20:42:55 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 20:44:32 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe606306eef3e6e273309c2b84a7dd756fd49621
Cr-Commit-Position: refs/heads/master@{#300325}

Powered by Google App Engine
This is Rietveld 408576698