Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 663813003: [Password Manager] Update SQL database version in response to rollback (Closed)

Created:
6 years, 2 months ago by Garrett Casto
Modified:
6 years, 2 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Update SQL database version in response to rollback Version was decreased from 8 to 7 after crrev.com/e8c29d4. This shouldn't affect very many people since the 7 -> 8 change was broken and no profiles would be updated, but it would affect Canary users that created new profiles. To be safe, keep the new version around but without any database changes. BUG=423716 Committed: https://crrev.com/04a35bf0f11e33bfe1852669e98787b6e4aec7b6 Cr-Commit-Position: refs/heads/master@{#300142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M components/password_manager/core/browser/login_database.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Garrett Casto
6 years, 2 months ago (2014-10-17 17:49:02 UTC) #2
aurimas (slooooooooow)
lgtm
6 years, 2 months ago (2014-10-17 17:50:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663813003/1
6 years, 2 months ago (2014-10-17 17:51:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 19:32:27 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 19:34:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04a35bf0f11e33bfe1852669e98787b6e4aec7b6
Cr-Commit-Position: refs/heads/master@{#300142}

Powered by Google App Engine
This is Rietveld 408576698