Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 663793003: Relanding WebRTC real webcam browsertest for Android. (Closed)

Created:
6 years, 2 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Relanding WebRTC real webcam browsertest for Android. Over the original patch that got reverted, this takes into account that the android device can be in a different orientation. If the nexus device happens to be in portrait mode in the lab, it will report a 480x640 resolution rather than 640x480, so this reland accounts for that. The main purpose of this test is to test the capture path on Android, i.e. that we can acquire the device's built-in webcam. If we happen to run on a device without a camera, we'll quietly succeed the test. BUG=323921 R=tommi Committed: https://crrev.com/8ba44ef0ac3b81bca7d1d93f29b8458c68430c4e Cr-Commit-Position: refs/heads/master@{#300655}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed override/virtual #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -8 lines) Patch
M content/browser/media/webrtc_internals_browsertest.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
A content/browser/media/webrtc_webcam_browsertest.cc View 1 1 chunk +102 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/media/getusermedia-real-webcam.html View 1 chunk +36 lines, -0 lines 0 comments Download
M content/test/data/media/webrtc_test_utilities.js View 1 chunk +16 lines, -0 lines 0 comments Download
M content/test/webrtc_content_browsertest_base.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
phoglund_chromium
6 years, 2 months ago (2014-10-20 17:04:46 UTC) #2
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/663793003/diff/1/content/browser/media/webrtc_webcam_browsertest.cc File content/browser/media/webrtc_webcam_browsertest.cc (right): https://codereview.chromium.org/663793003/diff/1/content/browser/media/webrtc_webcam_browsertest.cc#newcode47 content/browser/media/webrtc_webcam_browsertest.cc:47: virtual ~WebRtcWebcamBrowserTest() {} fyi - the new style ...
6 years, 2 months ago (2014-10-21 20:37:31 UTC) #4
phoglund_chromium
https://codereview.chromium.org/663793003/diff/1/content/browser/media/webrtc_webcam_browsertest.cc File content/browser/media/webrtc_webcam_browsertest.cc (right): https://codereview.chromium.org/663793003/diff/1/content/browser/media/webrtc_webcam_browsertest.cc#newcode47 content/browser/media/webrtc_webcam_browsertest.cc:47: virtual ~WebRtcWebcamBrowserTest() {} On 2014/10/21 20:37:30, tommi wrote: > ...
6 years, 2 months ago (2014-10-22 07:11:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663793003/20001
6 years, 2 months ago (2014-10-22 07:12:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/82227) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/71880) android_arm64_dbg_recipe ...
6 years, 2 months ago (2014-10-22 07:15:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663793003/40001
6 years, 2 months ago (2014-10-22 07:33:31 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-22 08:54:21 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 08:56:37 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8ba44ef0ac3b81bca7d1d93f29b8458c68430c4e
Cr-Commit-Position: refs/heads/master@{#300655}

Powered by Google App Engine
This is Rietveld 408576698