Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 663763003: Remove most of the None DEPS entries for iOS (Closed)

Created:
6 years, 2 months ago by stuartmorgan
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove most of the None DEPS entries for iOS Several of these are cruft (the entries don't exist to suppress), and the rest are all small (<20MB) so there's no real value in avoiding the pull. BUG=None Committed: https://crrev.com/75aa137c42979e30c37661c3a6e87d9cc95e7dfd Cr-Commit-Position: refs/heads/master@{#300186}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M DEPS View 1 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
stuartmorgan
I think we should actually eliminate all of these, but I thought I'd start with ...
6 years, 2 months ago (2014-10-17 20:30:52 UTC) #2
rohitrao (ping after 24h)
lgtm
6 years, 2 months ago (2014-10-17 20:34:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663763003/1
6 years, 2 months ago (2014-10-17 20:47:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/80571) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/70212) win_gpu ...
6 years, 2 months ago (2014-10-17 20:50:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663763003/20001
6 years, 2 months ago (2014-10-17 22:19:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-17 23:37:37 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 23:38:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75aa137c42979e30c37661c3a6e87d9cc95e7dfd
Cr-Commit-Position: refs/heads/master@{#300186}

Powered by Google App Engine
This is Rietveld 408576698