Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 663713002: [fsp] Extract ObservedEntry and ObservedEntries to a separate file. (Closed)

Created:
6 years, 2 months ago by mtomasz
Modified:
6 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

[fsp] Extract ObservedEntry and ObservedEntries to a separate file. Before they were part of the interface, which should be clean and simple. Moreover, this CL lets pass the list of changes via ProvidedFileSystemObserver which will be required soon in the Service class. TEST=unit_tests, browser_tests: *FileSystemProvider* BUG=248427 Committed: https://crrev.com/b9bac4b512b768e2d17e9199cc1a66997c55aaf3 Cr-Commit-Position: refs/heads/master@{#300071}

Patch Set 1 #

Patch Set 2 : Added missing files. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -65 lines) Patch
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 1 chunk +1 line, -2 lines 0 comments Download
A chrome/browser/chromeos/file_system_provider/observed_entry.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/observed_entry.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h View 3 chunks +1 line, -14 lines 2 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_interface.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h View 3 chunks +5 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc View 12 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mtomasz
@fukino: PTAL. Thanks!
6 years, 2 months ago (2014-10-17 03:47:13 UTC) #2
fukino
Thanks! lgtm with a nit. https://codereview.chromium.org/663713002/diff/20001/chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h File chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h (right): https://codereview.chromium.org/663713002/diff/20001/chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h#newcode18 chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h:18: #include "chrome/browser/chromeos/file_system_provider/observed_entry.h" nit: unneeded ...
6 years, 2 months ago (2014-10-17 04:51:02 UTC) #3
mtomasz
Thanks! https://codereview.chromium.org/663713002/diff/20001/chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h File chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h (right): https://codereview.chromium.org/663713002/diff/20001/chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h#newcode18 chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h:18: #include "chrome/browser/chromeos/file_system_provider/observed_entry.h" On 2014/10/17 04:51:02, fukino wrote: > ...
6 years, 2 months ago (2014-10-17 05:29:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663713002/20001
6 years, 2 months ago (2014-10-17 05:30:31 UTC) #6
fukino
On 2014/10/17 05:29:43, mtomasz wrote: > Thanks! > > https://codereview.chromium.org/663713002/diff/20001/chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h > File > chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h > ...
6 years, 2 months ago (2014-10-17 05:36:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-17 06:22:41 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 06:23:34 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b9bac4b512b768e2d17e9199cc1a66997c55aaf3
Cr-Commit-Position: refs/heads/master@{#300071}

Powered by Google App Engine
This is Rietveld 408576698