Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 663683007: Moves WindowManagerInternal* into own .mojom (Closed)

Created:
6 years, 1 month ago by sky
Modified:
6 years, 1 month ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Moves WindowManagerInternal* into own .mojom Only the ViewManager and WindowManager implementations care about these. BUG=none TEST=none R=ben@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/375f5733834de9d7cb21e24142cd972c90d641f1

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -31 lines) Patch
M mojo/services/public/interfaces/window_manager/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/interfaces/window_manager/window_manager.mojom View 1 1 chunk +0 lines, -22 lines 0 comments Download
A + mojo/services/public/interfaces/window_manager/window_manager_internal.mojom View 1 1 chunk +0 lines, -7 lines 0 comments Download
M mojo/services/view_manager/connection_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/window_manager/window_manager_internal_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
6 years, 1 month ago (2014-10-27 20:13:28 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 1 month ago (2014-10-27 20:20:01 UTC) #2
sky
6 years, 1 month ago (2014-10-27 20:33:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
375f5733834de9d7cb21e24142cd972c90d641f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698