Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 663673002: Convert the few remaining ARRAYSIZE_UNSAFE -> arraysize. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, stevenjb+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, oshima+watch_chromium.org, tfarina, darin (slow to review), ben+mojo_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert the few remaining ARRAYSIZE_UNSAFE -> arraysize. There are still ARRAYSIZE_UNSAFEs in ppapi/tests/test_audio.cc, but it defines it itself, and it might be compiled by some older NaCl toolchain that doesn't support C++11. third_party/npapi/npspy/common/format.cpp also has its own ARRAYSIZE_UNSAFE, but I'm hoping to delete npspy completely.) I'll remove ARRAYSIZE_UNSAFE from base/macro.h separately, since it's quite likely we have deps that use our base (and those deps may use it). R=ben@chromium.org TBR=armansito@chromium.org BUG=423134 Committed: https://crrev.com/2560ad88c6c237d40db5bf2e377cd552c33ef6ea Cr-Commit-Position: refs/heads/master@{#300034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -70 lines) Patch
M android_webview/browser/scoped_app_gl_state_restore.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/network_cert_migrator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_change_notifier_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/hmac_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_uuid_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_report_descriptor_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M gin/converter_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M google_apis/drive/drive_api_url_generator_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/examples/window_manager/debug_panel.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/cld/base/basictypes.h View 3 chunks +1 line, -48 lines 0 comments Download
M tools/gn/label_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
viettrungluu
6 years, 2 months ago (2014-10-16 23:10:30 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 2 months ago (2014-10-17 00:02:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663673002/1
6 years, 2 months ago (2014-10-17 00:29:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/18242)
6 years, 2 months ago (2014-10-17 00:42:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663673002/1
6 years, 2 months ago (2014-10-17 01:00:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 01:21:01 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 01:21:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2560ad88c6c237d40db5bf2e377cd552c33ef6ea
Cr-Commit-Position: refs/heads/master@{#300034}

Powered by Google App Engine
This is Rietveld 408576698