chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm - Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm

Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.h ('k') | chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm b/chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm

index 0f7bf68b49a19f6349b873513868c216524a74e2..1ab0111e24fbfcd172169e0e7023fe70d41fd76a 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm

@@ -403,13 +403,13 @@ const CGFloat kMinimumContentsHeight = 101;

[mainContainer_ validate];

}

-- (content::NavigationController*)showSignIn {

+- (content::NavigationController*)showSignIn:(const GURL&)url {

[self updateSignInSizeConstraints];

// Ensure |signInContainer_| is set to the same size as |mainContainer_|, to

// force its minimum size so that there will not be a resize until the

// contents are loaded.

[[signInContainer_ view] setFrameSize:[[mainContainer_ view] frame].size];

- [signInContainer_ loadSignInPage];

+ [signInContainer_ loadSignInPage:url];

[[signInContainer_ view] setHidden:NO];

[self updateMainContainerVisibility];