Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 663623002: Don't hide home card upon activation change (Closed)

Created:
6 years, 2 months ago by oshima
Modified:
6 years, 2 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Don't hide home card upon activation change. The test requires another CL and will be added later. BUG=None Committed: https://crrev.com/ce456f5712500634cec49c14ebe74b1a96fa9f05 Cr-Commit-Position: refs/heads/master@{#300121}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -34 lines) Patch
M athena/home/home_card_impl.h View 4 chunks +4 lines, -16 lines 0 comments Download
M athena/home/home_card_impl.cc View 5 chunks +1 line, -18 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
oshima
6 years, 2 months ago (2014-10-16 21:04:20 UTC) #3
Jun Mukai
not sure how athena/content changes are related to this topic. Can you explain briefly (or ...
6 years, 2 months ago (2014-10-16 21:07:10 UTC) #4
oshima
On 2014/10/16 21:07:10, Jun Mukai wrote: > not sure how athena/content changes are related to ...
6 years, 2 months ago (2014-10-16 21:09:54 UTC) #5
Jun Mukai
Still, those NOTIMPLEMENTEDs are looking nothing related to home card and activations.
6 years, 2 months ago (2014-10-16 21:11:16 UTC) #6
oshima
PTAL
6 years, 2 months ago (2014-10-17 08:41:34 UTC) #8
Jun Mukai
lgtm
6 years, 2 months ago (2014-10-17 16:43:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663623002/60001
6 years, 2 months ago (2014-10-17 16:44:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years, 2 months ago (2014-10-17 17:16:35 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 17:17:23 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce456f5712500634cec49c14ebe74b1a96fa9f05
Cr-Commit-Position: refs/heads/master@{#300121}

Powered by Google App Engine
This is Rietveld 408576698