Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 663593002: Move SessionRestore.* histograms to public histograms.xml file. (Closed)

Created:
6 years, 2 months ago by aiolos (Not reviewing)
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move SessionRestore.* histograms to public histograms.xml file. BUG=424229, 223859 NOTRY=true Committed: https://crrev.com/05c5bafe9dd6b827e42ccf55c49f1b7efa7451b3 Cr-Commit-Position: refs/heads/master@{#299987}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove histogram description. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +143 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
aiolos (Not reviewing)
Public half.
6 years, 2 months ago (2014-10-16 19:17:38 UTC) #2
Ilya Sherman
https://codereview.chromium.org/663593002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/663593002/diff/1/tools/metrics/histograms/histograms.xml#newcode29853 tools/metrics/histograms/histograms.xml:29853: + The time from SessionRestore start until all tabs ...
6 years, 2 months ago (2014-10-16 21:25:47 UTC) #4
aiolos (Not reviewing)
On 2014/10/16 21:25:47, Ilya Sherman wrote: > https://codereview.chromium.org/663593002/diff/1/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml (right): > > https://codereview.chromium.org/663593002/diff/1/tools/metrics/histograms/histograms.xml#newcode29853 ...
6 years, 2 months ago (2014-10-16 21:53:19 UTC) #5
Ilya Sherman
LGTM, thanks.
6 years, 2 months ago (2014-10-16 21:55:26 UTC) #6
aiolos (Not reviewing)
On 2014/10/16 21:55:26, Ilya Sherman wrote: > LGTM, thanks. Is there an order that submitting ...
6 years, 2 months ago (2014-10-16 21:57:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663593002/20001
6 years, 2 months ago (2014-10-16 22:00:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-16 22:03:27 UTC) #10
Ilya Sherman
On 2014/10/16 21:57:10, aiolos wrote: > On 2014/10/16 21:55:26, Ilya Sherman wrote: > > LGTM, ...
6 years, 2 months ago (2014-10-16 22:03:50 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 22:04:42 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/05c5bafe9dd6b827e42ccf55c49f1b7efa7451b3
Cr-Commit-Position: refs/heads/master@{#299987}

Powered by Google App Engine
This is Rietveld 408576698