Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 663583002: Remove AutoScratchTexture (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove AutoScratchTexture Remove AST from GrClipMaskCache Remove AST from GrClipMaskManager BUG=skia:2889 R=robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/427cf28861867c0ea9aafca3a23878ec4068ad99

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix tabbing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -90 lines) Patch
M include/gpu/GrContext.h View 2 chunks +0 lines, -62 lines 0 comments Download
M src/gpu/GrClipMaskCache.h View 8 chunks +12 lines, -11 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 4 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
bsalomon
6 years, 2 months ago (2014-10-16 19:14:49 UTC) #1
robertphillips
lgtm + nit Hooray!! https://codereview.chromium.org/663583002/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/663583002/diff/1/src/gpu/GrClipMaskManager.cpp#newcode616 src/gpu/GrClipMaskManager.cpp:616: temp.reset(this->createTempMask(maskSpaceIBounds.fRight, tab this over?
6 years, 2 months ago (2014-10-16 20:28:25 UTC) #2
bsalomon
https://codereview.chromium.org/663583002/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/663583002/diff/1/src/gpu/GrClipMaskManager.cpp#newcode616 src/gpu/GrClipMaskManager.cpp:616: temp.reset(this->createTempMask(maskSpaceIBounds.fRight, On 2014/10/16 20:28:25, robertphillips wrote: > tab this ...
6 years, 2 months ago (2014-10-16 20:34:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663583002/20001
6 years, 2 months ago (2014-10-16 20:35:21 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 20:42:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 427cf28861867c0ea9aafca3a23878ec4068ad99

Powered by Google App Engine
This is Rietveld 408576698